r51835 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51834‎ | r51835 | r51836 >
Date:19:21, 13 June 2009
Author:siebrand
Status:deferred
Tags:
Comment:
* makeLinkObj() -> link()
* update command line option documentation
Modified paths:
  • /trunk/extensions/Translate/TranslatePage.php (modified) (history)
  • /trunk/extensions/Translate/scripts/fuzzy.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslatePage.php
@@ -302,12 +302,16 @@
303303 private function makeOffsetLink( $label, $offset ) {
304304 global $wgUser;
305305 $skin = $wgUser->getSkin();
306 - $link = $skin->makeLinkObj( $this->getTitle(), $label,
307 - wfArrayToCGI(
308 - array( 'offset' => $offset ),
309 - $this->nondefaults
310 - )
 306+ $query = array_merge(
 307+ 'offset' => $offset,
 308+ $this->nondefaults
311309 );
 310+ $link = $skin->link(
 311+ $this->getTitle(),
 312+ $label,
 313+ array(),
 314+ $query
 315+ );
312316 return $link;
313317 }
314318
Index: trunk/extensions/Translate/scripts/fuzzy.php
@@ -19,8 +19,8 @@
2020 Usage: php fuzzy.php [options...] <messages>
2121
2222 Options:
23 - --really Don't just run dry-run
24 - --skiplanguages Skip some languages
 23+ --really Really fuzzy, no dry-run
 24+ --skiplanguages Skip some languages (comma separated)
2525 --comment Comment for updating
2626
2727 EOT

Follow-up revisions

RevisionCommit summaryAuthorDate
r51836Follow-up to r51835: actually merge to arrays.siebrand19:27, 13 June 2009
r52063Fix paging broken in r51835.siebrand18:22, 17 June 2009

Status & tagging log