r51682 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r51681‎ \| r51682 \| r51683 >
Date:	05:45, 10 June 2009
Author:	tstarling
Status:	deferred
Tags:
Comment:	Use require not include, to avoid possible register_globals vulnerability.
Modified paths:	/trunk/extensions/gis/kml.php (modified) (history)

Diff [purge]

Index: trunk/extensions/gis/kml.php
—	—	@@ -35,7 +35,7 @@
36	36
37	37	$wgGisVersion = '0.5alpha';
38	38
39		~~-include_once ( "gissettings.php" ) ;~~
	39	+require_once ( "gissettings.php" ) ;
40	40
41	41	if ( isset ( $wikibasedir ) )
42	42	{

Follow-up revisions

Revision	Commit summary	Author	Date
r51683	Backported r51682, possible security fix.	tstarling	05:48, 10 June 2009

Status & tagging log

05:02, 15 June 2009 Tim Starling (talk | contribs) changed the status of r51682 [removed: new added: deferred]