r51667 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51666‎ | r51667 | r51668 >
Date:23:01, 9 June 2009
Author:demon
Status:ok
Tags:
Comment:
(bug 19112) Preferences now respects $wgUseExternalEditor, $wgExternalDiffEngine. Patch by jidanni.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
@@ -639,18 +639,27 @@
640640 'section' => 'editing/advancedediting',
641641 'label-message' => 'tog-minordefault',
642642 );
643 - $defaultPreferences['externaleditor'] =
644 - array(
645 - 'type' => 'toggle',
646 - 'section' => 'editing/advancedediting',
647 - 'label-message' => 'tog-externaleditor',
648 - );
649 - $defaultPreferences['externaldiff'] =
650 - array(
651 - 'type' => 'toggle',
652 - 'section' => 'editing/advancedediting',
653 - 'label-message' => 'tog-externaldiff',
654 - );
 643+
 644+ global $wgUseExternalEditor;
 645+ if ($wgUseExternalEditor) {
 646+ $defaultPreferences['externaleditor'] =
 647+ array(
 648+ 'type' => 'toggle',
 649+ 'section' => 'editing/advancedediting',
 650+ 'label-message' => 'tog-externaleditor',
 651+ );
 652+ }
 653+
 654+ global $wgExternalDiffEngine;
 655+ if ($wgExternalDiffEngine) {
 656+ $defaultPreferences['externaldiff'] =
 657+ array(
 658+ 'type' => 'toggle',
 659+ 'section' => 'editing/advancedediting',
 660+ 'label-message' => 'tog-externaldiff',
 661+ );
 662+ }
 663+
655664 $defaultPreferences['forceeditsummary'] =
656665 array(
657666 'type' => 'toggle',
Index: trunk/phase3/RELEASE-NOTES
@@ -181,6 +181,7 @@
182182 * (bug 18925) history.js removes class names of list elements on initialization
183183 * Multiple whitespace in TOC anchors is now stripped, for consistency with the
184184 link from the edit comment
 185+* (bug 19112) Preferences now respects $wgUseExternalEditor, $wgExternalDiffEngine
185186
186187 == API changes in 1.16 ==
187188

Follow-up revisions

RevisionCommit summaryAuthorDate
r51736Fix for r51667: external diff is also controlled by $wgUseExternalEditor (see...ialex10:49, 11 June 2009

Status & tagging log