r51547 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r51546‎ | r51547 | r51548 >
Date:17:07, 6 June 2009
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Follow-up to r51543: Fix another syntax error in ImageGallery.php. Sorry.
Modified paths:
  • /trunk/phase3/includes/ImageGallery.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImageGallery.php
——@@ -299,7 +299,7 @@
300300 $textlink = $this->mShowFilename ?
301301 $sk->link(
302302 $nt,
303 - htmlspecialchars( $wgLang->truncate( $nt->getText(), 20 ) )
 303+ htmlspecialchars( $wgLang->truncate( $nt->getText(), 20 ) ),
304304 array(),
305305 array(),
306306 array( 'known', 'noclasses' )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r51543* replace use of deprecated makeLink() by link() in core...siebrand17:00, 6 June 2009

Comments

#Comment by Tim Starling (talk | contribs)   02:33, 11 June 2009

You could try running php -l on all the files you changed, before commit. It may make a useful addition to all the testing and proof-reading you're obviously doing already.

#Comment by Siebrand (talk | contribs)   02:41, 11 June 2009

Yes, have to start doing that more consistently.

Status & tagging log