r51390 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r51389‎ | r51390 | r51391 >
Date:08:16, 3 June 2009
Author:shinjiman
Status:reverted
Tags:
Comment:
follow up r51128, adding type check for $wgUser->getOption( 'variantconversion' ) whether it is 0 (disabled) or null (have not been set).
Modified paths:
  • /trunk/phase3/languages/LanguageConverter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/LanguageConverter.php
——@@ -430,7 +430,7 @@
431431
432432 /* disable entire conversion engine if the user had been disabled it */
433433 $variantConv = $wgUser->getOption( 'variantconversion' );
434 - if ( ( $wgEnableVariants == true ) && ( $variantConv == 0 ) ) {
 434+ if ( ( $wgEnableVariants == true ) && ( $variantConv === 0 ) ) {
435435 $wgEnableVariants = false;
436436 }
437437

Follow-up revisions

RevisionCommit summaryAuthorDate
r51460Revert r51128, and its follow-up revisions r51129, r51130, r51390....werdna09:48, 4 June 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r51128* (bug 18958) Added ability to disable entire variant conversion engine per u...shinjiman18:13, 28 May 2009

Status & tagging log