r51246 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r51245‎ | r51246 | r51247 >
Date:17:10, 31 May 2009
Author:rainman
Status:ok
Tags:
Comment:
Lastest followup to r50207: show create article link only for content and everything searches.. when searching in other
groups of namespaces this link might be a bit misplaced and confused.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
——@@ -233,7 +233,7 @@
234234 $wgOut->addHtml( "<div class='searchresults'>" );
235235
236236 // show direct page/create link
237 - if( !is_null($t) ) {
 237+ if( !is_null($t) && ($this->active=='default' || $this->active=='all') ) {
238238 if( !$t->exists() ) {
239239 $wgOut->addWikiMsg( 'searchmenu-new', wfEscapeWikiText( $t->getPrefixedText() ) );
240240 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r52665Revert r51246 for now. It might not be *always* appropriate to show the page ...rainman23:37, 1 July 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50207Redesign of the "new search UI" per Trevor's design plans from usability wiki:...rainman23:07, 4 May 2009

Status & tagging log