r51045 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51044‎ | r51045 | r51046 >
Date:05:30, 27 May 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Reverted r47352, $wgRateLimitsExcludedIPs is to be replaced by APCOND_ISIP.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -1169,17 +1169,10 @@
11701170 */
11711171 public function isPingLimitable() {
11721172 global $wgRateLimitsExcludedGroups;
1173 - global $wgRateLimitsExcludedIPs;
11741173 if( array_intersect( $this->getEffectiveGroups(), $wgRateLimitsExcludedGroups ) ) {
11751174 // Deprecated, but kept for backwards-compatibility config
11761175 return false;
11771176 }
1178 - if( in_array( wfGetIP(), $wgRateLimitsExcludedIPs ) ) {
1179 - // No other good way currently to disable rate limits
1180 - // for specific IPs. :P
1181 - // But this is a crappy hack and should die.
1182 - return false;
1183 - }
11841177 return !$this->isAllowed('noratelimit');
11851178 }
11861179
Index: trunk/phase3/includes/DefaultSettings.php
@@ -3326,12 +3326,6 @@
33273327 $wgRateLimitsExcludedGroups = array();
33283328
33293329 /**
3330 - * Array of IPs which should be excluded from rate limits.
3331 - * This may be useful for whitelisting NAT gateways for conferences, etc.
3332 - */
3333 -$wgRateLimitsExcludedIPs = array();
3334 -
3335 -/**
33363330 * On Special:Unusedimages, consider images "used", if they are put
33373331 * into a category. Default (false) is not to count those as used.
33383332 */

Follow-up revisions

RevisionCommit summaryAuthorDate
r57908Reintroduced $wgRateLimitsExcludedIPs from r47352 (removed in r51045). $wgAut...tstarling19:11, 19 October 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47352Added $wgRateLimitsExcludedIPs feature, based on live hack.tstarling03:17, 17 February 2009

Status & tagging log