r50871 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50870‎ | r50871 | r50872 >
Date:20:32, 21 May 2009
Author:mrzman
Status:ok
Tags:
Comment:
(bug 18860) Allow non-anon-only blocks of IPs to block email
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Block.php (modified) (history)
  • /trunk/phase3/skins/common/block.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/block.js
@@ -42,11 +42,6 @@
4343 if( autoblockRow ) {
4444 autoblockRow.style.display = isIp && !isEmpty ? 'none' : '';
4545 }
46 -
47 - var emailblockRow = document.getElementById('wpEnableEmailBan');
48 - if( emailblockRow ) {
49 - emailblockRow.style.display = isIp && !isEmpty ? 'none' : '';
50 - }
5146
5247 var hideuserRow = document.getElementById('wpEnableHideUser');
5348 if( hideuserRow ) {
Index: trunk/phase3/includes/Block.php
@@ -453,9 +453,12 @@
454454 # Unset ipb_enable_autoblock for IP blocks, makes no sense
455455 if ( !$this->mUser ) {
456456 $this->mEnableAutoblock = 0;
457 - $this->mBlockEmail = 0; //Same goes for email...
 457+
458458 }
459 -
 459+ # bug 18860: non-anon-only IP blocks should be allowed to block email
 460+ if ( !$this->mUser && $this->mAnonOnly ) {
 461+ $this->mBlockEmail = 0;
 462+ }
460463 if( !$this->mByName ) {
461464 if( $this->mBy ) {
462465 $this->mByName = User::whoIs( $this->mBy );
Index: trunk/phase3/RELEASE-NOTES
@@ -66,6 +66,7 @@
6767 * (bug 5755) Introduce {{CURRENTMONTH1}} and {{LOCALMONTH1}} to display the
6868 month number without the leading zero
6969 * (bug 13456) categoriespagetext supports PLURAL
 70+* (bug 18860) Blocks of IPs affecting registered users can now block email
7071
7172 === Bug fixes in 1.16 ===
7273

Status & tagging log