r50807 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50806‎ | r50807 | r50808 >
Date:03:02, 20 May 2009
Author:shinjiman
Status:ok (Comments)
Tags:
Comment:
additional date format for Taiwan Chinese language, per code review on r50778.
Modified paths:
  • /trunk/phase3/languages/messages/MessagesZh_tw.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesZh_tw.php
@@ -41,24 +41,39 @@
4242 $datePreferences = array(
4343 'default',
4444 'minguo',
 45+ 'minguo text',
 46+ 'minguo fulltext',
4547 'CNS 7648',
 48+ 'CNS 7648 compact',
4649 'ISO 8601',
4750 );
4851
4952 $defaultDateFormat = 'zh';
5053
5154 $dateFormats = array(
52 - 'zh time' => 'H:i',
53 - 'zh date' => 'Y年n月j日 (l)',
54 - 'zh both' => 'Y年n月j日 (D) H:i',
 55+ 'zh time' => 'H:i',
 56+ 'zh date' => 'Y年n月j日 (l)',
 57+ 'zh both' => 'Y年n月j日 (D) H:i',
5558
56 - 'minguo time' => 'H:i',
57 - 'minguo date' => 'xoY年n月j日 (l)',
58 - 'minguo both' => 'xoY年n月j日 (D) H:i',
 59+ 'minguo time' => 'H:i',
 60+ 'minguo date' => 'xoY年n月j日 (l)',
 61+ 'minguo both' => 'xoY年n月j日 (D) H:i',
5962
60 - 'CNS 7648 time' => 'H:i',
61 - 'CNS 7648 date' => 'R.O.C. xoY-m-d (l)',
62 - 'CNS 7648 both' => 'R.O.C. xoY-m-d (D) H:i',
 63+ 'minguo text time' => 'H:i',
 64+ 'minguo text date' => '民國xoY年n月j日 (l)',
 65+ 'minguo text both' => '民國xoY年n月j日 (D) H:i',
 66+
 67+ 'minguo fulltext time' => 'H:i',
 68+ 'minguo fulltext date' => '中華民國xoY年n月j日 (l)',
 69+ 'minguo fulltext both' => '中華民國xoY年n月j日 (D) H:i',
 70+
 71+ 'CNS 7648 time' => 'H:i',
 72+ 'CNS 7648 date' => 'R.O.C. xoY-m-d (l)',
 73+ 'CNS 7648 both' => 'R.O.C. xoY-m-d (D) H:i',
 74+
 75+ 'CNS 7648 compact time' => 'H:i',
 76+ 'CNS 7648 compact date' => 'ROC xoY-m-d (l)',
 77+ 'CNS 7648 compact both' => 'ROC xoY-m-d (D) H:i',
6378 );
6479
6580 $messages = array(

Follow-up revisions

RevisionCommit summaryAuthorDate
r51328Follow up r50807, adding double quotes around literal texts so that they will...shinjiman06:04, 2 June 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50778added Minguo calendar support for the Taiwan Chinese languageshinjiman16:38, 19 May 2009

Comments

#Comment by Tim Starling (talk | contribs)   05:47, 2 June 2009

Please add double quotes around literal ASCII letters such as "ROC", so that the formats don't break when we add support for more letters to sprintfDate.

#Comment by Shinjiman (talk | contribs)   06:05, 2 June 2009

Fixed in r51328.

Status & tagging log