r50788 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50787‎ | r50788 | r50789 >
Date:19:19, 19 May 2009
Author:aaron
Status:ok (Comments)
Tags:
Comment:
(bug 17060) Renders edit comments the same for all users wrt to revdelete
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)
  • /trunk/phase3/includes/PageHistory.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -654,7 +654,6 @@
655655 $tables = array( 'logging', 'user' );
656656 $this->mConds[] = 'user_id = log_user';
657657 $groupBy = false;
658 - $index = array();
659658 # Add log_search table if there are conditions on it
660659 if( array_key_exists('ls_field',$this->mConds) ) {
661660 $tables[] = 'log_search';
Index: trunk/phase3/includes/PageHistory.php
@@ -373,14 +373,11 @@
374374 function revLink( $rev ) {
375375 global $wgLang;
376376 $date = $wgLang->timeanddate( wfTimestamp(TS_MW, $rev->getTimestamp()), true );
377 - if( $rev->userCan( Revision::DELETED_TEXT ) ) {
 377+ if( !$rev->isDeleted( Revision::DELETED_TEXT ) ) {
378378 $link = $this->mSkin->makeKnownLinkObj( $this->mTitle, $date, "oldid=" . $rev->getId() );
379379 } else {
380 - $link = $date;
 380+ $link = "<span class=\"history-deleted\">$date</span>";
381381 }
382 - if( $rev->isDeleted( Revision::DELETED_TEXT ) ) {
383 - $link = "<span class=\"history-deleted\">$link</span>";
384 - }
385382 return $link;
386383 }
387384

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47059Tweaks for bug 17060...aaron22:27, 9 February 2009

Comments

#Comment by Aaron Schulz (talk | contribs)   19:20, 19 May 2009

Oh, LogEventsList.php change was removing a redundant line.

Status & tagging log