r50600 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r50599
|
r50600
|
r50601
>
Date:
20:29, 14 May 2009
Author:
demon
Status:
ok (
Comments
)
Tags:
Comment:
Followup to
r50423
: Check if the row is null, since older revs don't necessarily have rev_len populated.
Modified paths:
/trunk/phase3/includes/api/ApiQueryUserContributions.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/api/ApiQueryUserContributions.php
—
—
@@ -289,7 +289,7 @@
290
290
if ($this->fld_patrolled && $row->rc_patrolled)
291
291
$vals['patrolled'] = '';
292
292
293
- if ($this->fld_size )
293
+ if ( $this->fld_size && !is_null( $this->fld_size ) )
294
294
$vals['size'] = intval($row->rev_len);
295
295
296
296
return $vals;
Follow-up revisions
Revision
Commit summary
Author
Date
r50623
Fix up
r50600
, which had no effect
catrope
10:42, 15 May 2009
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r50423
API: (
bug 18743
) Add ucprop=size (enabled by default) to list=usercontribs. A...
catrope
09:25, 10 May 2009
Comments
#
Comment by
Catrope
(
talk
|
contribs
)
09:55, 15 May 2009
!is_null($this->fld_size) should be !is_null($row->rev_len)
Status & tagging log
17:05, 4 January 2012
Johnduhart
(
talk
|
contribs
)
changed the
tags
for r50600
[
removed:
api]
16:40, 19 May 2009
Tim Starling
(
talk
|
contribs
)
changed the
status
of r50600
[
removed:
new
added:
ok]
10:42, 15 May 2009
Catrope
(
talk
|
contribs
)
changed the
status
of r50600
[
removed:
fixme
added:
resolved]
09:55, 15 May 2009
Catrope
(
talk
|
contribs
)
changed the
tags
for r50600
[
added:
api]
09:55, 15 May 2009
Catrope
(
talk
|
contribs
)
changed the
status
of r50600
[
removed:
ok
added:
fixme]
21:20, 14 May 2009
Brion VIBBER
(
talk
|
contribs
)
changed the
status
of r50600
[
removed:
new
added:
ok]