r50535 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50534‎ | r50535 | r50536 >
Date:19:50, 12 May 2009
Author:ialex
Status:deferred
Tags:
Comment:
Use $wgOpenIDLoginLogoUrl rather than hardcoding the image to "http://www.openid.net/login-bg.gif"
Modified paths:
  • /trunk/extensions/OpenID/SpecialOpenIDConvert.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/SpecialOpenIDConvert.body.php
@@ -93,7 +93,8 @@
9494 }
9595
9696 function form() {
97 - global $wgOut, $wgUser;
 97+ global $wgOut, $wgUser, $wgOpenIDLoginLogoUrl;
 98+
9899 $sk = $wgUser->getSkin();
99100 $url = $this->GetUserUrl( $wgUser );
100101 if ( is_null( $url ) ) {
@@ -105,7 +106,7 @@
106107 $wgOut->addHTML( "<p>{$instructions}</p>" .
107108 '<form action="' . $sk->makeSpecialUrl( 'OpenIDConvert' ) . '" method="POST">' .
108109 '<input type="text" name="openid_url" size="30" ' .
109 - ' style="background: url(http://www.openid.net/login-bg.gif) ' .
 110+ ' style="background: url(' . $wgOpenIDLoginLogoUrl . ') ' .
110111 ' no-repeat; background-color: #fff; background-position: 0 50%; ' .
111112 ' color: #000; padding-left: 18px;" value="' . $url . '" />' .
112113 '<input type="submit" value="' . $ok . '" />' .

Status & tagging log