r50534 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50533‎ | r50534 | r50535 >
Date:19:08, 12 May 2009
Author:ialex
Status:deferred
Tags:
Comment:
* fix E_NOTICE about undefined index in $_SESSION
* fix XHTML error in login form
Modified paths:
  • /trunk/extensions/OpenID/SpecialOpenIDLogin.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/SpecialOpenIDLogin.body.php
@@ -116,7 +116,7 @@
117117 $smallButtonsHTML .= '</div>';
118118 }
119119
120 - $wgOut->addHTML( '<form id="openid_form" action="' . $sk->makeSpecialUrl( 'OpenIDLogin' ) . '" method="POST" onsubmit="openid.update()"">' .
 120+ $wgOut->addHTML( '<form id="openid_form" action="' . $sk->makeSpecialUrl( 'OpenIDLogin' ) . '" method="POST" onsubmit="openid.update()">' .
121121 '<fieldset><legend>' . wfMsg( 'openidsigninorcreateaccount' ) . '</legend>' .
122122 $largeButtonsHTML .
123123 '<div id="openid_input_area">' .
@@ -218,7 +218,7 @@
219219 }
220220
221221 function returnTo() {
222 - return $_SESSION['openid_consumer_returnto'];
 222+ return isset( $_SESSION['openid_consumer_returnto'] ) ? $_SESSION['openid_consumer_returnto'] : '';
223223 }
224224
225225 function setReturnTo( $returnto ) {

Status & tagging log