r50526 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50525‎ | r50526 | r50527 >
Date:18:00, 12 May 2009
Author:tomasz
Status:deferred (Comments)
Tags:
Comment:
fixing spacing
Modified paths:
  • /trunk/backup/worker.py (modified) (history)

Diff [purge]

Index: trunk/backup/worker.py
@@ -444,10 +444,10 @@
445445
446446 def reportFile(self, file, status):
447447 filepath = self.publicPath(file)
448 - if status == "in-progress" and exists (filepath):
 448+ if status == "in-progress" and exists (filepath):
449449 size = prettySize(getsize(filepath))
450450 return "<li class='file'>%s %s (written) </li>" % (file, size)
451 - elif status == "done" and exists(filepath):
 451+ elif status == "done" and exists(filepath):
452452 size = prettySize(getsize(filepath))
453453 webpath = self.webPath(file)
454454 return "<li class='file'><a href=\"%s\">%s</a> %s</li>" % (webpath, file, size)

Follow-up revisions

RevisionCommit summaryAuthorDate
r51000Bug fix for #18808. Moving XmlLogging into it's own class for clarity. Removi...tomasz03:35, 26 May 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   23:12, 13 May 2009

Looks like you've got a mix of tabs and spaces. :(

#Comment by Siebrand (talk | contribs)   22:54, 11 July 2011

This rev has been marked "todo" for the past 2 years. Quick check came up with almost 90 todos. What's the meaning of this tag, as it is very unspecific and appears to have little to no value if it is not resolved after two years...

#Comment by Tfinc (talk | contribs)   23:00, 11 July 2011

Fixed in r51000

Status & tagging log