r50510 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50509‎ | r50510 | r50511 >
Date:09:42, 12 May 2009
Author:jojo
Status:ok
Tags:
Comment:
fix potential JS error
Modified paths:
  • /trunk/extensions/Collection/collection/popup.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/collection/popup.js
@@ -77,7 +77,9 @@
7878 }
7979 }
8080 coll = JSON.parse(xhr.responseText);
81 - add_articles(coll.collection.items);
 81+ if (typeof coll.collection.items != 'undefined' ) {
 82+ add_articles(coll.collection.items);
 83+ }
8284 if (articles.length > 0) {
8385 startCollectionPopups();
8486 } else {

Status & tagging log