r50509 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50508‎ | r50509 | r50510 >
Date:08:37, 12 May 2009
Author:thomasv
Status:ok
Tags:
Comment:
always create the button; use display:none if we want to hide it
Modified paths:
  • /trunk/extensions/ProofreadPage/proofread.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/proofread.js
@@ -845,15 +845,17 @@
846846 ' <span class="quality0"> <input type="radio" name="quality" onclick="pr_add_quality(this.form,0)"> </span>'
847847 +'<span class="quality2"> <input type="radio" name="quality" onclick="pr_add_quality(this.form,2)"> </span>'
848848 +'<span class="quality1"> <input type="radio" name="quality" onclick="pr_add_quality(this.form,1)"> </span>'
849 -+'<span class="quality3"> <input type="radio" name="quality" onclick="pr_add_quality(this.form,3)"> </span>';
 849++'<span class="quality3"> <input type="radio" name="quality" onclick="pr_add_quality(this.form,3)"> </span>'
 850++'<span class="quality4"> <input type="radio" name="quality" onclick="pr_add_quality(this.form,4)"> </span>';
 851+ f.innerHTML = f.innerHTML + '&nbsp;'+proofreadPageMessageStatus;
 852+ ig.parentNode.insertBefore(f,ig.nextSibling.nextSibling.nextSibling);
850853
851854 var show4 = false;
852855 if(self.proofreadpage_quality==4) show4 = true;
853856 if((self.proofreadpage_quality==3) && (self.proofreadpage_username != wgUserName)) show4 = true;
854 - if(show4) f.innerHTML = f.innerHTML
855 -+ '<span class="quality4"> <input type="radio" name="quality" onclick="pr_add_quality(this.form,4)"> </span>';
856 - f.innerHTML = f.innerHTML + '&nbsp;'+proofreadPageMessageStatus;
857 - ig.parentNode.insertBefore(f,ig.nextSibling.nextSibling.nextSibling);
 857+ if(!show4)
 858+ document.editform.quality[4].parentNode.style.cssText='display:none';
 859+
858860 if(self.proofreadpage_quality) {
859861 switch(self.proofreadpage_quality){
860862 case 4: document.editform.quality[4].checked=true; break;

Status & tagging log