r50370 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50369‎ | r50370 | r50371 >
Date:14:25, 9 May 2009
Author:ialex
Status:deferred (Comments)
Tags:
Comment:
Fix for r50365: use tabs for identation; not spaces
Modified paths:
  • /trunk/extensions/Poll/Poll.i18n.php (modified) (history)
  • /trunk/extensions/Poll/Poll_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Poll/Poll_body.php
@@ -15,13 +15,13 @@
1616 $action = htmlentities( $wgRequest->getText( 'action' ) );
1717 $id = htmlentities( $wgRequest->getText( 'id' ) );
1818
19 - if($action == "create") {
20 - $this->create();
21 - }
22 -
23 - if($action == "vote") {
24 - $this->vote();
25 - }
 19+ if ( $action == "create" ) {
 20+ $this->create();
 21+ }
 22+
 23+ if ( $action == "vote" ) {
 24+ $this->vote();
 25+ }
2626 }
2727
2828 public function create() {
@@ -29,12 +29,12 @@
3030
3131 $wgOut->setPagetitle( wfMsg( 'poll-title-create' ) );
3232
33 - $controll_create_right = $wgUser->isAllowed('poll-create');
 33+ $controll_create_right = $wgUser->isAllowed( 'poll-create' );
3434 $controll_create_blocked = $wgUser->isBlocked();
35 - if( $controll_create_right != true ) {
 35+ if ( $controll_create_right != true ) {
3636 $wgOut->addWikiMsg( 'poll-create-right-error' );
3737 }
38 - elseif( $controll_create_blocked == true ) {
 38+ elseif ( $controll_create_blocked == true ) {
3939 $wgOut->addWikiMsg( 'poll-create-block-error' );
4040 }
4141 else {
@@ -47,12 +47,12 @@
4848
4949 $wgOut->setPagetitle( wfMsg( 'poll-title-vote' ) );
5050
51 - $controll_create_right = $wgUser->isAllowed('poll-vote');
 51+ $controll_create_right = $wgUser->isAllowed( 'poll-vote' );
5252 $controll_create_blocked = $wgUser->isBlocked();
53 - if( $controll_create_right != true ) {
 53+ if ( $controll_create_right != true ) {
5454 $wgOut->addWikiMsg( 'poll-vote-right-error' );
5555 }
56 - elseif( $controll_create_blocked == true ) {
 56+ elseif ( $controll_create_blocked == true ) {
5757 $wgOut->addWikiMsg( 'poll-vote-block-error' );
5858 }
5959 else {
Index: trunk/extensions/Poll/Poll.i18n.php
@@ -12,23 +12,23 @@
1313 $messages['en'] = array(
1414 'poll' => 'Polls',
1515 'poll-desc' => 'Add a [[Special:Poll|special page]] for using polls',
16 - 'poll-title-create' => 'Create a new poll',
17 - 'poll-title-vote' => 'Voting page',
18 - 'poll-title-score' => 'Score',
19 - 'poll-create-right-error' => 'You are not allowed to create a new poll(needed right: poll-create)',
20 - 'poll-create-block-error' => 'You are not allowed to create a new poll because you use a blocked user',
21 - 'poll-vote-right-error' => 'You are not allowed to vote(needed right: poll-vote)',
22 - 'poll-vote-block-error' => 'You are not allowed to vote because you use a blocked user',
 16+ 'poll-title-create' => 'Create a new poll',
 17+ 'poll-title-vote' => 'Voting page',
 18+ 'poll-title-score' => 'Score',
 19+ 'poll-create-right-error' => 'You are not allowed to create a new poll(needed right: poll-create)',
 20+ 'poll-create-block-error' => 'You are not allowed to create a new poll because you use a blocked user',
 21+ 'poll-vote-right-error' => 'You are not allowed to vote(needed right: poll-vote)',
 22+ 'poll-vote-block-error' => 'You are not allowed to vote because you use a blocked user',
2323 );
2424
2525 $messages['de'] = array(
2626 'poll' => 'Umfragen',
2727 'poll-desc' => 'Erstellt eine [[Special:Poll|Spezialsite]], um Umfragen zu nutzen',
28 - 'poll-title-create' => 'Eine neue Umfrage erstellen',
29 - 'poll-title-vote' => 'Abstimmen',
30 - 'poll-title-score' => 'Auswertung',
31 - 'poll-create-right-error' => 'Leider darfst du keine neue Umfrage erstellen(ben�tige Gruppenberechttigung: poll-create)',
32 - 'poll-create-block-error' => 'Leider darfst du keine neue Umfrage erstellen, weil du einen gesperten Benutzer benutzt',
33 - 'poll-vote-right-error' => 'Leider darfst du nicht abstimmen(ben�tige Gruppenberechttigung: poll-vote)',
34 - 'poll-vote-block-error' => 'Leider darfst du nicht abstimmen, weil du einen gesperten Benutzer benutzt',
 28+ 'poll-title-create' => 'Eine neue Umfrage erstellen',
 29+ 'poll-title-vote' => 'Abstimmen',
 30+ 'poll-title-score' => 'Auswertung',
 31+ 'poll-create-right-error' => 'Leider darfst du keine neue Umfrage erstellen(ben�tige Gruppenberechttigung: poll-create)',
 32+ 'poll-create-block-error' => 'Leider darfst du keine neue Umfrage erstellen, weil du einen gesperten Benutzer benutzt',
 33+ 'poll-vote-right-error' => 'Leider darfst du nicht abstimmen(ben�tige Gruppenberechttigung: poll-vote)',
 34+ 'poll-vote-block-error' => 'Leider darfst du nicht abstimmen, weil du einen gesperten Benutzer benutzt',
3535 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50365* Add new messages...jan12:09, 9 May 2009

Comments

#Comment by Jan Luca (talk | contribs)   20:42, 9 May 2009

With which editor do you do this?

#Comment by IAlex (talk | contribs)   16:10, 10 May 2009

I did this manually using Xcode.

Status & tagging log