r50354 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50353‎ | r50354 | r50355 >
Date:23:48, 8 May 2009
Author:tomasz
Status:resolved (Comments)
Tags:
Comment:
Fixing incorrect link to main page and temp fix till ubuntu bug #370618 is fixed
Modified paths:
  • /trunk/backup/report.html (modified) (history)
  • /trunk/backup/worker.py (modified) (history)

Diff [purge]

Index: trunk/backup/worker.py
@@ -831,12 +831,14 @@
832832 # Clear prior 7zip attempts; 7zip will try to append an existing archive
833833 if exists(xml7z):
834834 os.remove(xml7z)
835 -
836 - command = "%s -dc < %s | %s a -si %s" % shellEscape((
 835+
 836+ # temp hack force 644 permissions until ubuntu bug # 370618 is fixed - tomasz 5/1/2009
 837+ command = "%s -dc < %s | %s a -si %s ; chmod 644 %s" % shellEscape((
837838 runner.config.bzip2,
838839 xmlbz2,
839840 runner.config.sevenzip,
840 - xml7z));
 841+ xml7z,
 842+ xml7z));
841843 return runner.runCommand(command, callback=self.progressCallback)
842844
843845 def listFiles(self, runner):
Index: trunk/backup/report.html
@@ -67,7 +67,7 @@
6868 for documentation on the provided data formats.
6969 </p>
7070
71 - <p>See <a href="../../">all databases list</a>.</p>
 71+ <p>See <a href="../../backup-index.html">all databases list</a>.</p>
7272
7373 <p class="previous">
7474 %(previous)s

Follow-up revisions

RevisionCommit summaryAuthorDate
r59947Fixed backup-index.html location per Brion's comment on r50354. Untested.tstarling06:39, 11 December 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   17:46, 11 May 2009

There's a config option for setting the index output file, should use this rather than hardcoding.

Status & tagging log