r50331 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r50330‎ | r50331 | r50332 >
Date:09:03, 8 May 2009
Author:ialex
Status:deferred (Comments)
Tags:
Comment:
more fixes for r50316: changed StartProfiler.php to ProfilerStub.php so that it doesn't break when StartProfiler.php doesn't exist
Modified paths:
  • /trunk/phase3/t/inc/Database.t (modified) (history)
  • /trunk/phase3/t/inc/Global.t (modified) (history)

Diff [purge]

Index: trunk/phase3/t/inc/Global.t
——@@ -5,7 +5,7 @@
66 require 't/Test.php';
77
88 require 'includes/Defines.php';
9 -require 'StartProfiler.php';
 9+require 'includes/ProfilerStub.php';
1010 require 'includes/AutoLoader.php';
1111 require 'LocalSettings.php';
1212 require 'includes/Setup.php';
Index: trunk/phase3/t/inc/Database.t
——@@ -5,7 +5,7 @@
66 require 't/Test.php';
77
88 require 'includes/Defines.php';
9 -require 'StartProfiler.php';
 9+require 'includes/ProfilerStub.php';
1010 require 'includes/AutoLoader.php';
1111 require 'LocalSettings.php';
1212 require 'includes/Setup.php';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50316Removed StartProfiler.php from SVN control and added StartProfiler.sample fil...aaron18:30, 7 May 2009

Comments

#Comment by Aaron Schulz (talk | contribs)   14:35, 8 May 2009

How many places is this stuff duplicated?

#Comment by IAlex (talk | contribs)   18:03, 11 May 2009

Dunno exactely, but maybe half of tests in t/inc (somes uses commandLine.inc; others only includes specific files).

Status & tagging log