r50217 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50216‎ | r50217 | r50218 >
Date:13:12, 5 May 2009
Author:tstarling
Status:deferred
Tags:
Comment:
API backports:
* r49954 (without formatting and doc changes): fix continue parameter in generator=backlinks
* r49956: fix exception
* r50041: use xml:space="preserve"
Modified paths:
  • /branches/REL1_15/phase3 (modified) (history)
  • /branches/REL1_15/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_15/phase3/includes (modified) (history)
  • /branches/REL1_15/phase3/includes/api (modified) (history)
  • /branches/REL1_15/phase3/includes/api/ApiBase.php (modified) (history)
  • /branches/REL1_15/phase3/includes/api/ApiFormatXml.php (modified) (history)
  • /branches/REL1_15/phase3/includes/api/ApiQueryBacklinks.php (modified) (history)
  • /branches/REL1_15/phase3/includes/specials (modified) (history)

Diff [purge]

Index: branches/REL1_15/phase3/includes/api/ApiQueryBacklinks.php
@@ -206,6 +206,7 @@
207207 $this->extractRowInfo($row);
208208 else
209209 {
 210+ $this->pageMap[$row->page_namespace][$row->page_title] = $row->page_id;
210211 if($row->page_is_redirect)
211212 $this->redirTitles[] = Title::makeTitle($row->page_namespace, $row->page_title);
212213 $resultPageSet->processDbRow($row);
Index: branches/REL1_15/phase3/includes/api/ApiFormatXml.php
@@ -89,6 +89,11 @@
9090 if ($this->mDoubleQuote)
9191 $subElemContent = $this->doubleQuote($subElemContent);
9292 unset ($elemValue['*']);
 93+
 94+ // Add xml:space="preserve" to the
 95+ // element so XML parsers will leave
 96+ // whitespace in the content alone
 97+ $elemValue['xml:space'] = 'preserve';
9398 } else {
9499 $subElemContent = null;
95100 }
Index: branches/REL1_15/phase3/includes/api/ApiBase.php
@@ -610,7 +610,7 @@
611611 * @return mixed (allowMultiple ? an_array_of_values : a_single_value)
612612 */
613613 protected function parseMultiValue($valueName, $value, $allowMultiple, $allowedValues) {
614 - if( trim($value) === "" )
 614+ if( trim($value) === "" && $allowMultiple)
615615 return array();
616616 $sizeLimit = $this->mMainModule->canApiHighLimits() ? self::LIMIT_SML2 : self::LIMIT_SML1;
617617 $valuesList = explode('|', $value, $sizeLimit + 1);
Property changes on: branches/REL1_15/phase3/includes/api
___________________________________________________________________
Name: svn:mergeinfo
618618 - /trunk/phase3/includes/api:48813-48814,48819,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,50070,50169
619619 + /trunk/phase3/includes/api:48813-48814,48819,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,50041,50070,50169
Property changes on: branches/REL1_15/phase3/includes/specials
___________________________________________________________________
Name: svn:mergeinfo
620620 - /trunk/phase3/includes/specials:48836,48886,48892,48989,48992-48993,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,50070,50169
/trunk/phase3/includes/specials/specials:48993
621621 + /trunk/phase3/includes/specials:48836,48886,48892,48989,48992-48993,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,50041,50070,50169
/trunk/phase3/includes/specials/specials:48993
Property changes on: branches/REL1_15/phase3/includes
___________________________________________________________________
Name: svn:mergeinfo
622622 - /trunk/phase3/includes:48836,48886,48892,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,50070,50169
/trunk/phase3/includes/specials:48993
623623 + /trunk/phase3/includes:48836,48886,48892,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,50041,50070,50169
/trunk/phase3/includes/specials:48993
Index: branches/REL1_15/phase3/RELEASE-NOTES
@@ -340,6 +340,9 @@
341341 * Fixed the circular template inclusion check, was broken when the loop
342342 involved redirects. Without this, infinite recursion within the parser is
343343 possible.
 344+* (bug 18601) generator=backlinks returns invalid continue parameter
 345+* (bug 18597) Internal error with empty generator= parameter
 346+* (bug 18617) Add xml:space="preserve" attribute to relevant tags in XML output
344347
345348 === Languages updated in 1.15 ===
346349
Property changes on: branches/REL1_15/phase3
___________________________________________________________________
Name: svn:mergeinfo
347350 - /trunk/phase3:48814,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,50070,50169
348351 + /trunk/phase3:48814,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,50041,50070,50169

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49954API: (bug 18601) generator=backlinks returns invalid continue parameter. Patc...catrope14:09, 27 April 2009
r49956API: Fix regression from r32224 with caused bug 18597 (internal error for emp...catrope14:21, 27 April 2009
r50041API: (bug 18617) Add xml:space="preserve" attribute to relevant tags in XML o...catrope13:12, 29 April 2009

Status & tagging log