r49954 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49953‎ | r49954 | r49955 >
Date:14:09, 27 April 2009
Author:catrope
Status:ok
Tags:
Comment:
API: (bug 18601) generator=backlinks returns invalid continue parameter. Patch by Brad Jorsch
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryBacklinks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryBacklinks.php
@@ -206,6 +206,7 @@
207207 $this->extractRowInfo($row);
208208 else
209209 {
 210+ $this->pageMap[$row->page_namespace][$row->page_title] = $row->page_id;
210211 if($row->page_is_redirect)
211212 $this->redirTitles[] = Title::makeTitle($row->page_namespace, $row->page_title);
212213 $resultPageSet->processDbRow($row);
@@ -229,7 +230,7 @@
230231 $parentID = $this->pageMap[$row->{$this->bl_ns}][$row->{$this->bl_title}];
231232 else
232233 $parentID = $this->pageMap[NS_IMAGE][$row->{$this->bl_title}];
233 - $this->continueStr = $this->getContinueRedirStr($parentID, $row->page_id);
 234+ $this->continueStr = $this->getContinueRedirStr($parentID, $row->page_id);
234235 break;
235236 }
236237
@@ -408,7 +409,7 @@
409410
410411 public function getParamDescription() {
411412 $retval = array (
412 - 'title' => 'Title to search. If null, titles= parameter will be used instead, but will be obsolete soon.',
 413+ 'title' => 'Title to search.',
413414 'continue' => 'When more results are available, use this to continue.',
414415 'namespace' => 'The namespace to enumerate.',
415416 'filterredir' => 'How to filter for redirects'
@@ -416,7 +417,7 @@
417418 if($this->getModuleName() != 'embeddedin')
418419 return array_merge($retval, array(
419420 'redirect' => 'If linking page is a redirect, find all pages that link to that redirect as well. Maximum limit is halved.',
420 - 'limit' => "How many total pages to return. If {$this->bl_code}redirect is enabled, limit applies to each level separately."
 421+ 'limit' => "How many total pages to return. If {$this->bl_code}redirect is enabled, limit applies to each level separately (which means you may get up to 2 * limit results)."
421422 ));
422423 return array_merge($retval, array(
423424 'limit' => "How many total pages to return."
Index: trunk/phase3/RELEASE-NOTES
@@ -435,7 +435,8 @@
436436 * (bug 18546) Added timestamp of new revision to action=edit output
437437 * (bug 18554) Also list hidden revisions in list=usercontribs for privileged
438438 users
439 -* (bug 13049) "API must be accessed from the primary script entry point" error
 439+* (bug 13049) "API must be accessed from the primary script entry point" error
 440+* (bug 18601) generator=backlinks returns invalid continue parameter
440441
441442 === Languages updated in 1.15 ===
442443

Follow-up revisions

RevisionCommit summaryAuthorDate
r50217API backports:...tstarling13:12, 5 May 2009

Status & tagging log