r50169 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50168‎ | r50169 | r50170 >
Date:09:42, 4 May 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Added release notes entry for user-visible change r49212: fix for template loop check. Users reported that this change broke their deliberately loopy templates.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -108,7 +108,11 @@
109109 * Removed float from the user login form in RTL interface - caused display
110110 problems in FF2
111111 * (bug 15008) Redirect images are now subject to Bad image list rules
 112+* Fixed the circular template inclusion check, was broken when the loop
 113+ involved redirects. Without this, infinite recursion within the parser is
 114+ possible.
112115
 116+
113117 == API changes in 1.16 ==
114118
115119 * Added uiprop=changeablegroups to meta=userinfo

Follow-up revisions

RevisionCommit summaryAuthorDate
r50170Backported r49212/r50169: template loop check didn't work when redirects were...tstarling09:46, 4 May 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49212Move the circular reference check to *after* redirect resolution, to avoid in...tstarling15:01, 5 April 2009

Status & tagging log