r50160 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50159‎ | r50160 | r50161 >
Date:21:36, 3 May 2009
Author:demon
Status:ok (Comments)
Tags:
Comment:
Revert r49959 (Fixed some CSS validation issues with colors)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -1426,7 +1426,7 @@
14271427 }
14281428
14291429 div#searchTarget ul li:before {
1430 - color: #ffa500;
 1430+ color: orange;
14311431 content: "\00BB \0020";
14321432 }
14331433
Index: trunk/phase3/skins/common/shared.css
@@ -159,7 +159,7 @@
160160 }
161161
162162 div.searchresults {
163 - border:1px solid #00008b;
 163+ border:1px solid darkblue;
164164 padding-top: 10px;
165165 padding-bottom: 10px;
166166 padding-left: 20px;
Index: trunk/phase3/RELEASE-NOTES
@@ -104,7 +104,6 @@
105105 languages while the the text is typed as URLs.
106106 * (bug 18535) Search tab tool-tops are corrupted
107107 * (bug 17614) Prev / Next links not need on ImagePage file history if less than limit
108 -* (bug 18069) Fixed some CSS validation issues with colors
109108 * (bug 18207) Strange spacing before [[irc:...]] links
110109 * Removed float from the user login form in RTL interface - caused display
111110 problems in FF2

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49959(bug 18069) Fixed some CSS validation issues with colorsdemon14:52, 27 April 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   22:26, 3 May 2009

Any reason for the revert?

#Comment by 😂 (talk | contribs)   22:29, 3 May 2009

Cf the comments on r49959. It's perfectly valid CSS how it was, the validator just complains for no real reason.

#Comment by Simetrical (talk | contribs)   13:22, 4 May 2009

(commenting to get e-mail followups)

Status & tagging log