r50130 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r50129‎ | r50130 | r50131 >
Date:14:24, 2 May 2009
Author:catrope
Status:ok (Comments)
Tags:
Comment:
API: (bug 18533) Add readonly message to meta=siteinfo output
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQuerySiteinfo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQuerySiteinfo.php
——@@ -128,8 +128,10 @@
129129 $data['rtl'] = '';
130130 $data['fallback8bitEncoding'] = $wgLang->fallback8bitEncoding();
131131
132 - if( wfReadOnly() )
 132+ if( wfReadOnly() ) {
133133 $data['readonly'] = '';
 134+ $data['readonlyreason'] = wfReadOnlyReason();
 135+ }
134136 if( $GLOBALS['wgEnableWriteAPI'] )
135137 $data['writeapi'] = '';
136138
Index: trunk/phase3/RELEASE-NOTES
——@@ -127,6 +127,7 @@
128128 * (bug 16422) Don't display help for format=jsonfm unless specifically requested
129129 * (bug 18617) Add xml:space="preserve" attribute to relevant tags in XML output
130130 * Added PHP and database version to meta=siteinfo output
 131+* (bug 18533) Add readonly message to meta=siteinfo output
131132
132133 === Languages updated in 1.16 ===
133134

Follow-up revisions

RevisionCommit summaryAuthorDate
r53132(bug 18533) Add readonly reason to readonly exceptionbtongminh12:38, 12 July 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   00:02, 6 May 2009

This seems to be passing wikitext straight out... is that ideal formatting?

#Comment by Catrope (talk | contribs)   14:21, 6 May 2009

Maybe not, but I'm not sure HTML is ideal either; also, if people really care they can always run the wikitext through action=parse

Status & tagging log