r50121 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50120‎ | r50121 | r50122 >
Date:07:44, 2 May 2009
Author:shinjiman
Status:ok (Comments)
Tags:
Comment:
Change to show the checkout revision number by default in Special:Version, per Code Review on r50106.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -176,7 +176,7 @@
177177 $subVersionCo = self::getSvnRevision(dirname($extension['path']), true, true, false);
178178 $subVersionDir = self::getSvnRevision(dirname($extension['path']), false, true, true);
179179 if ($subVersionDir)
180 - $viewvc = $subVersionDir . $subVersion;
 180+ $viewvc = $subVersionDir . $subVersionCo;
181181 }
182182 if ( isset( $extension['version'] ) ) {
183183 $version = $extension['version'];
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -2853,7 +2853,7 @@
28542854 'version-hook-name' => 'Shown in [[Special:Version]]',
28552855 'version-hook-subscribedby' => 'Shown in [[Special:Version]]',
28562856 'version-version' => '{{Identical|Version}}',
2857 -'version-svn-revision' => 'This is being used in [[Special:Version]], preceeding the subversion revision numbers of both the core and the extensions loaded.
 2857+'version-svn-revision' => 'This is being used in [[Special:Version]], preceeding the subversion revision numbers of both the core and the extensions loaded. By default, only the checkout revision number is displayed. However this messages could be customised to display the last modified directory revision number.
28582858
28592859 * $1: last modified directory revision number
28602860 * $2: checkout directory revision number
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -3826,7 +3826,7 @@
38273827 'version-hook-name' => 'Hook name',
38283828 'version-hook-subscribedby' => 'Subscribed by',
38293829 'version-version' => '(Version $1)',
3830 -'version-svn-revision' => '(r$1/r$2)', # only translate this message to other languages if you have to change it
 3830+'version-svn-revision' => '(r$2)', # only translate this message to other languages if you have to change it
38313831 'version-license' => 'License',
38323832 'version-software' => 'Installed software',
38333833 'version-software-product' => 'Product',

Follow-up revisions

RevisionCommit summaryAuthorDate
r55130Fixes for Shinjiman's Special:Version updates r49995-r50121:...tstarling08:31, 16 August 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50106Follow up r49997, showing both last modified and checkout revision number for...shinjiman14:09, 1 May 2009

Comments

#Comment by Shinjiman (talk | contribs)   07:49, 2 May 2009

I've keeped the variable for the last changed directory revision number for customisation purposes for the site if needed.

When an old revision was checked-out, the "last changed directory revision" is always lesser than or equal to "checkout directory revision" (i.e. "last changed revision" <= "checkout revision").

#Comment by Brion VIBBER (talk | contribs)   00:10, 6 May 2009

Perfect, thanks! :D

Status & tagging log