r50111 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r50110‎ | r50111 | r50112 >
Date:19:08, 1 May 2009
Author:rotem
Status:ok (Comments)
Tags:
Comment:
Removed float from the user login form in RTL interface - caused display problems in FF2, and in LTR interfaces there is no float there.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/modern/rtl.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)
  • /trunk/phase3/skins/simple/rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/rtl.css
——@@ -211,7 +211,6 @@
212212 }
213213
214214 #userlogin {
215 - float: right;
216215 margin: 0 0 1em 3em;
217216 }
218217 /* Convenience links to edit block, delete and protect reasons */
Index: trunk/phase3/skins/modern/rtl.css
——@@ -79,7 +79,6 @@
8080 }
8181
8282 #userlogin {
83 - float: right;
8483 margin: 0 0 1em 3em;
8584 }
8685 /* Convenience links to edit block, delete and protect reasons */
Index: trunk/phase3/skins/simple/rtl.css
——@@ -148,7 +148,6 @@
149149 }
150150
151151 #userlogin {
152 - float: right;
153152 margin: 0 0 1em 3em;
154153 }
155154 /* Convenience links to edit block, delete and protect reasons */
Index: trunk/phase3/includes/DefaultSettings.php
——@@ -1477,7 +1477,7 @@
14781478 * to ensure that client-side caches don't keep obsolete copies of global
14791479 * styles.
14801480 */
1481 -$wgStyleVersion = '216';
 1481+$wgStyleVersion = '217';
14821482
14831483
14841484 # Server-side caching:
Index: trunk/phase3/RELEASE-NOTES
——@@ -106,6 +106,8 @@
107107 * (bug 17614) Prev / Next links not need on ImagePage file history if less than limit
108108 * (bug 18069) Fixed some CSS validation issues with colors
109109 * (bug 18207) Strange spacing before [[irc:...]] links
 110+* Removed float from the user login form in RTL interface - caused display
 111+ problems in FF2
110112
111113 == API changes in 1.16 ==
112114

Comments

#Comment by Brion VIBBER (talk | contribs)   23:58, 1 May 2009

The float is definitely still there in Monobook: 

div#userloginForm form,
div#userlogin form#userlogin2 {
	margin: 0 3em 1em 0;
	border: 1px solid #aaa;
	clear: both;
	padding: 1.5em 2em;
	background-color: #f9f9f9;
	float: left;
}
.rtl div#userloginForm form,
.rtl div#userlogin form#userlogin2 {
	float: right;
}

I believe a float is used here to get the div to size nicely to match its contents; without a float it expands to full width and looks weird.

If floats are problematic, then this either hasn't been solved, or it's just floating the wrong thing or wrong combination of things...

#Comment by Rotemliss (talk | contribs)   07:36, 2 May 2009

Floats were problematic in the specific case, because of a bug in FF2. In addition, in Monobook the float refers to a form element (not to the div#userlogin itself, which did not have float in LTR), and the second selector from main.css shows that the float in rtl.css was not necessary.

#Comment by Tim Starling (talk | contribs)   08:56, 4 June 2009

Good enough for me.

Status & tagging log