r50065 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50064‎ | r50065 | r50066 >
Date:05:28, 30 April 2009
Author:tstarling
Status:reverted (Comments)
Tags:
Comment:
Commit master changes on all ajax requests. There's no reason that this should be the responsibility of the callee. Causes annoying bugs when omitted.
Modified paths:
  • /trunk/phase3/index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/index.php
@@ -71,6 +71,7 @@
7272 require_once( $IP . '/includes/AjaxDispatcher.php' );
7373 $dispatcher = new AjaxDispatcher();
7474 $dispatcher->performAction();
 75+ wfGetLBFactory()->commitMasterChanges();
7576 $mediaWiki->restInPeace();
7677 exit;
7778 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r51046Reverted r50065, restInPeace does this since r49684.tstarling05:32, 27 May 2009

Comments

#Comment by Aaron Schulz (talk | contribs)   06:19, 30 April 2009

restInPeace() already commits since r49684

Status & tagging log