r50054 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r50053‎ | r50054 | r50055 >
Date:21:31, 29 April 2009
Author:brion
Status:ok (Comments)
Tags:
Comment:
Make export depth > 1 actually work. :) Assuming it doesn't bomb and die using too much memory, of course.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialExport.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialExport.php
——@@ -353,6 +353,7 @@
354354 $pageSet = $this->getLinks( $inputPages, $pageSet, 'pagelinks',
355355 array( 'pl_namespace AS namespace', 'pl_title AS title' ),
356356 array( 'page_id=pl_from' ) );
 357+ $inputPages = array_keys( $pageSet );
357358 }
358359 return $pageSet;
359360 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r50222Backports:...tstarling14:18, 5 May 2009

Comments

#Comment by Aaron Schulz (talk | contribs)   06:05, 30 April 2009

How does this change anything? That var is not returned or passed by ref.

#Comment by Tim Starling (talk | contribs)   10:07, 4 May 2009

It's in a loop. The output of getLinks() is fed back into the input on the second iteration.

Status & tagging log