r50011 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50010‎ | r50011 | r50012 >
Date:18:42, 28 April 2009
Author:brion
Status:ok
Tags:
Comment:
Follow-up to r49803: use proper type and add an explicit foreign key reference for up_user->user_id as we have for other tables in the postgresql schema
Modified paths:
  • /trunk/phase3/maintenance/postgres/archives/patch-user_properties.sql (modified) (history)
  • /trunk/phase3/maintenance/postgres/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/postgres/archives/patch-user_properties.sql
@@ -1,5 +1,5 @@
22 CREATE TABLE user_properties(
3 - up_user BIGINT NOT NULL,
 3+ up_user INTEGER NULL REFERENCES mwuser(user_id) ON DELETE CASCADE,
44 up_property TEXT NOT NULL,
55 up_value TEXT
66 );
Index: trunk/phase3/maintenance/postgres/tables.sql
@@ -581,7 +581,7 @@
582582 );
583583
584584 CREATE TABLE user_properties(
585 - up_user BIGINT NOT NULL,
 585+ up_user INTEGER NULL REFERENCES mwuser(user_id) ON DELETE CASCADE,
586586 up_property TEXT NOT NULL,
587587 up_value TEXT
588588 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49803Follow-up r49790: update the PostgreSQL schemaialex08:49, 24 April 2009

Status & tagging log