r49894 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49893‎ | r49894 | r49895 >
Date:06:49, 26 April 2009
Author:ialex
Status:reverted (Comments)
Tags:
Comment:
Per Raymond's comment at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/49885#c2292 : Don't show """ cannot be used as a page title" when no title was passed :)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialCreatePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialCreatePage.php
@@ -40,7 +40,7 @@
4141 // check for no title
4242 if ( $wgRequest->wasPosted() && $target === '' ) {
4343 $this->error( wfMsg( 'createpage-entertitle' ) );
44 - } elseif ( $target !== '' ) {
 44+ } elseif ( $target !== null ) {
4545 if ( !$title instanceof Title ) {
4646 // check for invalid title
4747 $this->error( wfMsg( 'createpage-badtitle', $target ) );

Comments

#Comment by Brion VIBBER (talk | contribs)   19:05, 27 April 2009

Reverted in r49973

Status & tagging log