r49438 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49437‎ | r49438 | r49439 >
Date:12:16, 13 April 2009
Author:demon
Status:deferred (Comments)
Tags:
Comment:
(bug 18441) rebuildrecentchanges.inc no longer ignores $wgLogRestrictions. Also a related fixme, now build this list automatically from $wgLogTypes.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/maintenance/rebuildrecentchanges.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/rebuildrecentchanges.inc
@@ -122,20 +122,10 @@
123123
124124 print( "Loading from user, page, and logging tables...\n" );
125125
126 - global $wgRCMaxAge;
127 - // Some logs don't go in RC. This can't really detect all of those.
128 - // At least do the basics logs for a standard install...
129 - // FIXME: this needs to be maintained
130 - $basicRCLogs = array(
131 - 'newusers',
132 - 'block',
133 - 'protect',
134 - 'rights',
135 - 'delete',
136 - 'upload',
137 - 'move',
138 - 'import',
139 - 'merge' );
 126+ global $wgRCMaxAge, $wgLogTypes, $wgLogRestrictions;
 127+ // Some logs don't go in RC. This should check for that
 128+ $baseRCLogs = array_diff( $wgLogTypes, array_keys( $wgLogRestrictions ) );
 129+
140130 // Escape...blah blah
141131 $selectLogs = array();
142132 foreach( $basicRCLogs as $logtype ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -342,6 +342,7 @@
343343 * (bug 18115) ForeignAPIRepo cache isn't working
344344 * Fixed a bug caused by LanguageConverter.php, which brings an abnormal '}-'
345345 after some parsed math syntax.
 346+* (bug 18441) rebuildrecentchanges.inc no longer ignores $wgLogRestrictions
346347
347348 == API changes in 1.15 ==
348349 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Comments

#Comment by Aaron Schulz (talk | contribs)   01:34, 14 April 2009

Be careful, now the patrol logs will always flood RC.

#Comment by 😂 (talk | contribs)   20:57, 2 May 2009

Just out of curiosity, where was the revision in which you hid patrol logs from RC anyway? Would be nice to do something similar here, and perhaps unify it (cf bug 18364)

Status & tagging log