r49154 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r49153‎ \| r49154 \| r49155 >
Date:	14:46, 3 April 2009
Author:	simetrical
Status:	ok
Tags:
Comment:	Remove superfluous border="0" from images This should be (and appears to be) handled just fine by CSS. If it breaks in any skins, those should have an appropriate CSS rule added.
Modified paths:	/trunk/extensions/Cite/citeParserTests.txt (modified) (history) /trunk/phase3/RELEASE-NOTES (modified) (history) /trunk/phase3/includes/MediaTransformOutput.php (modified) (history) /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
—	—	@@ -3130,7 +3130,7 @@
3131	3131	!! input
3132	3132	[[Image:foobar.jpg]]
3133	3133	!! result
3134		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Image:foobar.jpg"><img alt="Image:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3134	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Image:foobar.jpg"><img alt="Image:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3135	3135	</p>
3136	3136	!! end
3137	3137
—	—	@@ -3139,7 +3139,7 @@
3140	3140	!! input
3141	3141	[[Image:foobar.jpg\|right]]
3142	3142	!! result
3143		-<div class="floatright"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div>
	3143	+<div class="floatright"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a></div>
3144	3144
3145	3145	!! end
3146	3146
—	—	@@ -3148,7 +3148,7 @@
3149	3149	!! input
3150	3150	[[File:foobar.jpg]]
3151	3151	!! result
3152		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="File:foobar.jpg"><img alt="File:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3152	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="File:foobar.jpg"><img alt="File:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3153	3153	</p>
3154	3154	!! end
3155	3155
—	—	@@ -3157,7 +3157,7 @@
3158	3158	!! input
3159	3159	[[Image:foobar.jpg\|right\|Caption text]]
3160	3160	!! result
3161		-<div class="floatright"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Caption text"><img alt="Caption text" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div>
	3161	+<div class="floatright"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Caption text"><img alt="Caption text" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a></div>
3162	3162
3163	3163	!! end
3164	3164
—	—	@@ -3166,7 +3166,7 @@
3167	3167	!! input
3168	3168	[[Image:foobar.jpg\|link=Target page]]
3169	3169	!! result
3170		~~-<p><a href="https://www.mediawiki.org/wiki/Target_page" title="Target page"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>~~
	3170	+<p><a href="https://www.mediawiki.org/wiki/Target_page" title="Target page"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3171	3171	</p>
3172	3172	!! end
3173	3173
—	—	@@ -3175,7 +3175,7 @@
3176	3176	!! input
3177	3177	[[Image:foobar.jpg\|link=http://example.com/]]
3178	3178	!! result
3179		~~-<p><a href="http://example.com/"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>~~
	3179	+<p><a href="http://example.com/"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3180	3180	</p>
3181	3181	!! end
3182	3182
—	—	@@ -3184,7 +3184,7 @@
3185	3185	!! input
3186	3186	[[Image:foobar.jpg\|link=]]
3187	3187	!! result
3188		~~-<p><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" />~~
	3188	+<p><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" />
3189	3189	</p>
3190	3190	!! end
3191	3191
—	—	@@ -3195,7 +3195,7 @@
3196	3196	!! input
3197	3197	[[Image:Foobar.jpg\|frame\|left\|This is a test image [[Main Page]]]]
3198	3198	!! result
3199		-<div class="thumb tleft"><div class="thumbinner" style="width:1943px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is a test image Main Page"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" class="thumbimage" /></a> <div class="thumbcaption">This is a test image <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a></div></div></div>
	3199	+<div class="thumb tleft"><div class="thumbinner" style="width:1943px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is a test image Main Page"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" class="thumbimage" /></a> <div class="thumbcaption">This is a test image <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a></div></div></div>
3200	3200
3201	3201	!! end
3202	3202
—	—	@@ -3204,7 +3204,7 @@
3205	3205	!! input
3206	3206	[[Image:Foobar.jpg\|frame\|left\|This is a test image [[Main Page]]\|alt=Altitude]]
3207	3207	!! result
3208		-<div class="thumb tleft"><div class="thumbinner" style="width:1943px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is a test image Main Page"><img alt="Altitude" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" class="thumbimage" /></a> <div class="thumbcaption">This is a test image <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a></div></div></div>
	3208	+<div class="thumb tleft"><div class="thumbinner" style="width:1943px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is a test image Main Page"><img alt="Altitude" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" class="thumbimage" /></a> <div class="thumbcaption">This is a test image <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a></div></div></div>
3209	3209
3210	3210	!! end
3211	3211
—	—	@@ -3213,7 +3213,7 @@
3214	3214	!! input
3215	3215	[[Image:Foobar.jpg\|testing '''bold''' in alt]]
3216	3216	!! result
3217		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="testing bold in alt"><img alt="testing bold in alt" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3217	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="testing bold in alt"><img alt="testing bold in alt" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3218	3218	</p>
3219	3219	!! end
3220	3220
—	—	@@ -3222,7 +3222,7 @@
3223	3223	!! input
3224	3224	[[Image:Foobar.jpg\|alt=testing '''bold''' in alt]]
3225	3225	!! result
3226		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="testing bold in alt" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3226	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="testing bold in alt" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3227	3227	</p>
3228	3228	!! end
3229	3229
—	—	@@ -3242,7 +3242,7 @@
3243	3243	!! input
3244	3244	[[Image:foobar.jpg\|http://example.com]]
3245	3245	!! result
3246		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="http://example.com"><img alt="http://example.com" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3246	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="http://example.com"><img alt="http://example.com" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3247	3247	</p>
3248	3248	!! end
3249	3249
—	—	@@ -3251,7 +3251,7 @@
3252	3252	!! input
3253	3253	[[Image:foobar.jpg\|thumb\|http://example.com]]
3254	3254	!! result
3255		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="http://example.com"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a></div></div></div>
	3255	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="http://example.com"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a></div></div></div>
3256	3256
3257	3257	!! end
3258	3258
—	—	@@ -3260,7 +3260,7 @@
3261	3261	!! input
3262	3262	[[Image:foobar.jpg\|thumb\|http://example.com\|alt=Alteration]]
3263	3263	!! result
3264		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="http://example.com"><img alt="Alteration" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a></div></div></div>
	3264	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="http://example.com"><img alt="Alteration" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a></div></div></div>
3265	3265
3266	3266	!! end
3267	3267
—	—	@@ -3269,7 +3269,7 @@
3270	3270	!! input
3271	3271	[[Image:foobar.jpg\|thumb\|ISBN 1235467890]]
3272	3272	!! result
3273		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="ISBN 1235467890"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><a href="https://www.mediawiki.org/wiki/Special:BookSources/1235467890" class="internal">ISBN 1235467890</a></div></div></div>
	3273	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="ISBN 1235467890"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><a href="https://www.mediawiki.org/wiki/Special:BookSources/1235467890" class="internal">ISBN 1235467890</a></div></div></div>
3274	3274
3275	3275	!! end
3276	3276
—	—	@@ -3278,7 +3278,7 @@
3279	3279	!! input
3280	3280	[[Image:foobar.jpg\|thumb\|This is RFC 12354]]
3281	3281	!! result
3282		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is RFC 12354"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>This is <a href="http://tools.ietf.org/html/rfc12354" class="external" title="http://tools.ietf.org/html/rfc12354">RFC 12354</a></div></div></div>
	3282	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is RFC 12354"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>This is <a href="http://tools.ietf.org/html/rfc12354" class="external" title="http://tools.ietf.org/html/rfc12354">RFC 12354</a></div></div></div>
3283	3283
3284	3284	!! end
3285	3285
—	—	@@ -3287,7 +3287,7 @@
3288	3288	!! input
3289	3289	[[Image:foobar.jpg\|thumb\|Please mailto:nobody@example.com]]
3290	3290	!! result
3291		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Please mailto:nobody@example.com"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>Please <a href="mailto:nobody@example.com" class="external free" title="mailto:nobody@example.com" rel="nofollow">mailto:nobody@example.com</a></div></div></div>
	3291	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Please mailto:nobody@example.com"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>Please <a href="mailto:nobody@example.com" class="external free" title="mailto:nobody@example.com" rel="nofollow">mailto:nobody@example.com</a></div></div></div>
3292	3292
3293	3293	!! end
3294	3294
—	—	@@ -3297,7 +3297,7 @@
3298	3298	!! input
3299	3299	[[Image:foobar.jpg\|thumb\|<math>2+2</math>]]
3300	3300	!! result
3301		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="<math>2+2</math>"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><math>2+2</math></div></div></div>
	3301	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="<math>2+2</math>"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><math>2+2</math></div></div></div>
3302	3302
3303	3303	!! end
3304	3304
—	—	@@ -3308,7 +3308,7 @@
3309	3309	!! input
3310	3310	[[Image:foobar.jpg\|thumb\|<math>2+2</math>]]
3311	3311	!! result
3312		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="2 + 2"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><span class="texhtml">2 + 2</span></div></div></div>
	3312	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="2 + 2"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div><span class="texhtml">2 + 2</span></div></div></div>
3313	3313
3314	3314	!! end
3315	3315
—	—	@@ -3318,7 +3318,7 @@
3319	3319	!! input
3320	3320	[[Image:foobar.jpg\|text with a [[link]] in it]]
3321	3321	!! result
3322		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="text with a link in it"><img alt="text with a link in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3322	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="text with a link in it"><img alt="text with a link in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3323	3323	</p>
3324	3324	!! end
3325	3325
—	—	@@ -3327,7 +3327,7 @@
3328	3328	!! input
3329	3329	[[Image:foobar.jpg\|text with a [[link]]foo in it]]
3330	3330	!! result
3331		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="text with a linkfoo in it"><img alt="text with a linkfoo in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3331	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="text with a linkfoo in it"><img alt="text with a linkfoo in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3332	3332	</p>
3333	3333	!! end
3334	3334
—	—	@@ -3336,7 +3336,7 @@
3337	3337	!! input
3338	3338	[[Image:foobar.jpg\|text with a [[MeatBall:Link]] in it]]
3339	3339	!! result
3340		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="text with a MeatBall:Link in it"><img alt="text with a MeatBall:Link in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3340	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="text with a MeatBall:Link in it"><img alt="text with a MeatBall:Link in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3341	3341	</p>
3342	3342	!! end
3343	3343
—	—	@@ -3345,7 +3345,7 @@
3346	3346	!! input
3347	3347	[[Image:foobar.jpg\|text with a [[MeatBall:Link\|link]] in it]]
3348	3348	!! result
3349		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="text with a link in it"><img alt="text with a link in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3349	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="text with a link in it"><img alt="text with a link in it" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3350	3350	</p>
3351	3351	!! end
3352	3352
—	—	@@ -3354,7 +3354,7 @@
3355	3355	!! input
3356	3356	[[Image:foobar.jpg\|& < > "]]
3357	3357	!! result
3358		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="& < > ""><img alt="& < > "" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3358	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="& < > ""><img alt="& < > "" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3359	3359	</p>
3360	3360	!! end
3361	3361
—	—	@@ -3363,7 +3363,7 @@
3364	3364	!! input
3365	3365	[[Image:foobar.jpg\|♀]]
3366	3366	!! result
3367		~~-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="♀"><img alt="♀" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>~~
	3367	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="♀"><img alt="♀" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3368	3368	</p>
3369	3369	!! end
3370	3370
—	—	@@ -3381,7 +3381,7 @@
3382	3382	!! input
3383	3383	[[Image:Foobar.jpg\|thumb\|This is a caption with another [[Image:icon.png\|image]] inside it!]]
3384	3384	!! result
3385		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is a caption with another File:Icon.png inside it!"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>This is a caption with another <a href="https://www.mediawiki.org/index.php?title=Special:Upload&wpDestFile=Icon.png" class="new" title="File:Icon.png">File:Icon.png</a> inside it!</div></div></div>
	3385	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is a caption with another File:Icon.png inside it!"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>This is a caption with another <a href="https://www.mediawiki.org/index.php?title=Special:Upload&wpDestFile=Icon.png" class="new" title="File:Icon.png">File:Icon.png</a> inside it!</div></div></div>
3386	3386
3387	3387	!! end
3388	3388
—	—	@@ -3391,7 +3391,7 @@
3392	3392	[[Image:Foobar.jpg\|This
3393	3393	*is some text]]
3394	3394	!! result
3395		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is some text"><img alt="This is some text" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3395	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This is some text"><img alt="This is some text" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3396	3396	</p>
3397	3397	!!end
3398	3398
—	—	@@ -3401,7 +3401,7 @@
3402	3402	!! input
3403	3403	[[Image:Foobar.jpg\|thumb\|200px\|This caption has [irc://example.net irc] and [https://example.com Secure] ext links in it.]]
3404	3404	!! result
3405		-<div class="thumb tright"><div class="thumbinner" style="width:202px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This caption has irc and Secure ext links in it."><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/200px-Foobar.jpg" width="200" height="23" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>This caption has <a href="irc://example.net" class="external text" title="irc://example.net" rel="nofollow">irc</a> and <a href="https://example.com" class="external text" title="https://example.com" rel="nofollow">Secure</a> ext links in it.</div></div></div>
	3405	+<div class="thumb tright"><div class="thumbinner" style="width:202px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="This caption has irc and Secure ext links in it."><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/200px-Foobar.jpg" width="200" height="23" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>This caption has <a href="irc://example.net" class="external text" title="irc://example.net" rel="nofollow">irc</a> and <a href="https://example.com" class="external text" title="https://example.com" rel="nofollow">Secure</a> ext links in it.</div></div></div>
3406	3406
3407	3407	!! end
3408	3408
—	—	@@ -3804,7 +3804,7 @@
3805	3805	!! input
3806	3806	http://example.com [[Image:foobar.jpg]]
3807	3807	!! result
3808		-<p><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a> <a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Image:foobar.jpg"><img alt="Image:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3808	+<p><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a> <a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Image:foobar.jpg"><img alt="Image:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3809	3809	</p>
3810	3810	!!end
3811	3811
—	—	@@ -3813,7 +3813,7 @@
3814	3814	!! input
3815	3815	http://example.com[[Image:foobar.jpg]]
3816	3816	!! result
3817		-<p><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Image:foobar.jpg"><img alt="Image:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a>
	3817	+<p><a href="http://example.com" class="external free" title="http://example.com" rel="nofollow">http://example.com</a><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Image:foobar.jpg"><img alt="Image:foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a>
3818	3818	</p>
3819	3819	!!end
3820	3820
—	—	@@ -6321,7 +6321,7 @@
6322	6322	!! input
6323	6323	[[Image:foobar.jpg\|centre]]
6324	6324	!! result
6325		-<div class="center"><div class="floatnone"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div></div>
	6325	+<div class="center"><div class="floatnone"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a></div></div>
6326	6326
6327	6327	!!end
6328	6328
—	—	@@ -6330,7 +6330,7 @@
6331	6331	!! input
6332	6332	[[Image:foobar.jpg\|none]]
6333	6333	!! result
6334		-<div class="floatnone"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" border="0" /></a></div>
	6334	+<div class="floatnone"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" /></a></div>
6335	6335
6336	6336	!!end
6337	6337
—	—	@@ -6339,7 +6339,7 @@
6340	6340	!! input
6341	6341	[[Image:foobar.jpg\|640x480px]]
6342	6342	!! result
6343		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" border="0" /></a>
	6343	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" /></a>
6344	6344	</p>
6345	6345	!!end
6346	6346
—	—	@@ -6348,7 +6348,7 @@
6349	6349	!! input
6350	6350	[[Image:foobar.jpg\|640px]]
6351	6351	!! result
6352		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" border="0" /></a>
	6352	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" /></a>
6353	6353	</p>
6354	6354	!!end
6355	6355
—	—	@@ -6357,7 +6357,7 @@
6358	6358	!! input
6359	6359	[[Image:foobar.jpg\|640px ]]
6360	6360	!! result
6361		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" border="0" /></a>
	6361	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" /></a>
6362	6362	</p>
6363	6363	!!end
6364	6364
—	—	@@ -6366,7 +6366,7 @@
6367	6367	!! input
6368	6368	[[Image:foobar.jpg\| 640px]]
6369	6369	!! result
6370		-<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" border="0" /></a>
	6370	+<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/640px-Foobar.jpg" width="640" height="73" /></a>
6371	6371	</p>
6372	6372	!!end
6373	6373
—	—	@@ -6404,7 +6404,7 @@
6405	6405	!! input
6406	6406	[[image:Foobar.jpg\|thumb\|An [http://test/?param1=\|left\|&param2=\|x external] URL]]
6407	6407	!! result
6408		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="An external URL"><img alt="An external URL" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>An <a href="http://test/?param1=\|left\|&param2=\|x" class="external text" title="http://test/?param1=\|left\|&param2=\|x" rel="nofollow">external</a> URL</div></div></div>
	6408	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="An external URL"><img alt="An external URL" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>An <a href="http://test/?param1=\|left\|&param2=\|x" class="external text" title="http://test/?param1=\|left\|&param2=\|x" rel="nofollow">external</a> URL</div></div></div>
6409	6409
6410	6410	!!end
6411	6411
—	—	@@ -7218,7 +7218,7 @@
7219	7219	!! input
7220	7220	[[Image:Foobar.jpg\|thumb\|http://x\|hello]]
7221	7221	!! result
7222		-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="hello"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" border="0" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>hello</div></div></div>
	7222	+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="hello"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" width="180" height="20" class="thumbimage" /></a> <div class="thumbcaption"><div class="magnify"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>hello</div></div></div>
7223	7223
7224	7224	!! end
7225	7225
Index: trunk/phase3/includes/MediaTransformOutput.php
—	—	@@ -174,7 +174,6 @@
175	175	'src' => $this->url,
176	176	'width' => $this->width,
177	177	'height' => $this->height,
178		~~- 'border' => 0,~~
179	178	);
180	179	if ( !empty( $options['valign'] ) ) {
181	180	$attribs['style'] = "vertical-align: {$options['valign']}";
Index: trunk/phase3/RELEASE-NOTES
—	—	@@ -159,6 +159,7 @@
160	160	* Add group convertsion support for LanguageConverter. New magic word
161	161	"{{GROUPCONVERT:xxx}}" enabled for this new feature. You can set related
162	162	conversion rules in [[MediaWiki:Groupconversiontable-xxx/language_code]].
	163	+* Superfluous border="0" removed from images
163	164
164	165	=== Bug fixes in 1.15 ===
165	166	* (bug 16968) Special:Upload no longer throws useless warnings.
Index: trunk/extensions/Cite/citeParserTests.txt
—	—	@@ -113,7 +113,7 @@
114	114	<table class="gallery" cellspacing="0" cellpadding="0">
115	115	<tr>
116	116	<td><div class="gallerybox" style="width: 155px;">
117		- <div class="thumb" style="padding: 66px 0; width: 150px;"><div style="margin-left: auto; margin-right: auto; width: 120px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/120px-Foobar.jpg" width="120" height="14" border="0" /></a></div></div>
	117	+ <div class="thumb" style="padding: 66px 0; width: 150px;"><div style="margin-left: auto; margin-right: auto; width: 120px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/thumb/3/3a/Foobar.jpg/120px-Foobar.jpg" width="120" height="14" /></a></div></div>
118	118	<div class="gallerytext">
119	119	</div>
120	120	</div></td>

Status & tagging log

16:01, 3 June 2009 Tim Starling (talk | contribs) changed the status of r49154 [removed: new added: ok]