r49153 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49152‎ | r49153 | r49154 >
Date:13:49, 3 April 2009
Author:aaron
Status:ok
Tags:
Comment:
Correct empty case for r49149
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
@@ -156,7 +156,10 @@
157157 $first = $dbr->selectField( 'logging', 'log_timestamp',
158158 array('log_id' => $safeIds), __METHOD__, array('ORDER BY' => 'log_id') );
159159 # If there are no items, then stop here
160 - if( $first == false ) $conds = '1 = 0';
 160+ if( $first == false ) {
 161+ $conds = array('1=0');
 162+ return array($conds,$limit);
 163+ }
161164 # The event was be hidden after it was made
162165 $conds[] = 'log_timestamp > '.$dbr->addQuotes($first); // type,time index
163166 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49149RevisionDelete log extract query optimizationsaaron12:58, 3 April 2009

Status & tagging log