r49151 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49150‎ | r49151 | r49152 >
Date:13:27, 3 April 2009
Author:demon
Status:ok (Comments)
Tags:
Comment:
(bug 18311) Purging images via the API now works. This is why we should use articleFromTitle() rather than new Article().
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiPurge.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiPurge.php
@@ -65,7 +65,7 @@
6666 $result[] = $r;
6767 continue;
6868 }
69 - $article = new Article($title);
 69+ $article = Mediawiki::articleFromTitle( $title );
7070 $article->doPurge(); // Directly purge and skip the UI part of purge().
7171 $r['purged'] = '';
7272 $result[] = $r;
Index: trunk/phase3/RELEASE-NOTES
@@ -370,6 +370,7 @@
371371 message to be included in the page text
372372 * Added uiprop=changeablegroups to meta=userinfo
373373 * Added usprop=gender to list=users
 374+* (bug 18311) action=purge now works for images too
374375
375376 === Languages updated in 1.15 ===
376377

Comments

#Comment by Tim Starling (talk | contribs)   12:53, 5 May 2009

The bug is not severe enough for a backport.

Status & tagging log