r49086 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r49085‎ | r49086 | r49087 >
Date:15:57, 31 March 2009
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Fixed fatal from r49068. Removed verbose formatting :)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRecentchangeslinked.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRecentchangeslinked.php
——@@ -85,13 +85,8 @@
8686 $join_conds['watchlist'] = array( 'LEFT JOIN', "wl_user={$uid} AND wl_title=rc_title AND wl_namespace=rc_namespace" );
8787 }
8888
89 - ChangeTags::modifyDisplayQuery( $tables,
90 - $select,
91 - $conds,
92 - $join_conds,
93 - $query_options,
94 - $opts['tagfilter'],
95 - );
 89+ ChangeTags::modifyDisplayQuery( $tables, $select, $conds, $join_conds,
 90+ $query_options, $opts['tagfilter'] );
9691
9792 // XXX: parent class does this, should we too?
9893 // wfRunHooks('SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r50091Backported r49068, r49086: change tagging performance fixes.tstarling05:23, 1 May 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49068Fix tag filtering by adding a FORCE INDEX to the relevant querieswerdna13:01, 31 March 2009

Comments

#Comment by Jidanni (talk | contribs)   22:51, 31 March 2009

Maybe they should run php --syntax-check before uploading. P.S., how can I set notification if someone replies to this comment. Like bugzilla, it will email me at jidanni@jidanni.org for new comments to bugs I've commented on. How do I achieve the same here? Please email me to tell me how. Thanks.

#Comment by Simetrical (talk | contribs)   13:06, 1 April 2009

If you've set an e-mail address in your preferences and confirmed it, you should be receiving notifications for replies to comments, AFAIK.

#Comment by Jidanni (talk | contribs)   03:02, 7 April 2009

Wasn't enough. OK, now I've clicked every conceivable related preference. If I still don't get an e-mail generated by you (please) replying again, it means only committers get notified or something.

#Comment by Simetrical (talk | contribs)   13:24, 7 April 2009

If it doesn't work, file a bug report, I guess.

#Comment by Jidanni (talk | contribs)   00:00, 8 April 2009

OK, now it's working. I got the email.

(Sure hope one day I won't want to unsubscribe from (just) one of these threads. There probably is no way other than ripping up one's email address in Special:Preferences .)

Status & tagging log