r49051 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49050‎ | r49051 | r49052 >
Date:23:31, 30 March 2009
Author:aaron
Status:ok
Tags:
Comment:
(bug 18263) Escape single-quotes for wpDestForm
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -1157,8 +1157,7 @@
11581158 );
11591159 if( $this->mForReUpload ) {
11601160 $wgOut->addHTML(
1161 - "<input tabindex='2' type='hidden' name='wpDestFile' id='wpDestFile'
1162 - value='{$encDestName}' />" .
 1161+ Xml::hidden( 'wpDestFile', $this->mDesiredDestName, array('id'=>'wpDestFile','tabindex'=>2) ) .
11631162 "<tt>" .
11641163 $encDestName .
11651164 "</tt>"
@@ -1254,7 +1253,8 @@
12551254 <tr>
12561255 <td></td>
12571256 <td class='mw-input'>
1258 - <input tabindex='9' type='submit' name='wpUpload' value=\"{$ulb}\"" . $wgUser->getSkin()->tooltipAndAccesskey( 'upload' ) . " />
 1257+ <input tabindex='9' type='submit' name='wpUpload' value=\"{$ulb}\"" .
 1258+ $wgUser->getSkin()->tooltipAndAccesskey( 'upload' ) . " />
12591259 </td>
12601260 </tr>
12611261 <tr>

Follow-up revisions

RevisionCommit summaryAuthorDate
r50092Backported r49051/r49775: fixes unreleased XSStstarling06:06, 1 May 2009

Status & tagging log