r49008 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49007‎ | r49008 | r49009 >
Date:15:37, 29 March 2009
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Remove some makeKnownLinkObj() invocations in RC

Was being called for all rows, then thrown away for any rows that
weren't normal edits (logs, etc.).
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -560,15 +560,15 @@
561561 $querycur = $curIdEq."&diff=0&oldid=$rc_this_oldid";
562562 $querydiff = $curIdEq."&diff=$rc_this_oldid&oldid=$rc_last_oldid$rcIdQuery";
563563 $aprops = ' tabindex="'.$baseRC->counter.'"';
564 - $curLink = $this->skin->makeKnownLinkObj( $rc->getTitle(),
565 - $this->message['cur'], $querycur, '' ,'', $aprops );
566564
567565 # Make "diff" an "cur" links
568566 if( !$showdifflinks ) {
569 - $curLink = $this->message['cur'];
570 - $diffLink = $this->message['diff'];
 567+ $curLink = $this->message['cur'];
 568+ $diffLink = $this->message['diff'];
571569 } else if( in_array( $rc_type, array(RC_NEW,RC_LOG,RC_MOVE,RC_MOVE_OVER_REDIRECT) ) ) {
572 - $curLink = ($rc_type != RC_NEW) ? $this->message['cur'] : $curLink;
 570+ $curLink = ($rc_type != RC_NEW) ? $this->message['cur']
 571+ : $this->skin->makeKnownLinkObj( $rc->getTitle(),
 572+ $this->message['cur'], $querycur, '' ,'', $aprops );
573573 $diffLink = $this->message['diff'];
574574 } else {
575575 $diffLink = $this->skin->makeKnownLinkObj( $rc->getTitle(), $this->message['diff'],

Comments

#Comment by Simetrical (talk | contribs)   20:26, 29 March 2009

Note this was broken: I missed the last branch. Should be fixed in my next commit.

Status & tagging log