r48990 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48989‎ | r48990 | r48991 >
Date:11:04, 29 March 2009
Author:ialex
Status:ok
Tags:
Comment:
Fixes for r48930:
* Use user's language since it falls back to content if the message wasn't modified in user's language
* Fix a typo in RELEASE-NOTES
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -867,8 +867,8 @@
868868
869869 # Allow a specific header on talk pages, like [[MediaWiki:Talkpagetext]]
870870 if( $this->mTitle->isTalkPage() ) {
871 - if ( wfMsgForContent( 'talkpageheader' ) != '-' ) {
872 - $wgOut->wrapWikiMsg( "<div class=\"mw-talkpageheader\">\n$1</div>", array( 'talkpageheader', 'options' => array( 'content' ) ) );
 871+ if ( wfMsg( 'talkpageheader' ) != '-' ) {
 872+ $wgOut->wrapWikiMsg( "<div class=\"mw-talkpageheader\">\n$1</div>", array( 'talkpageheader' ) );
873873 }
874874 }
875875
Index: trunk/phase3/RELEASE-NOTES
@@ -152,8 +152,8 @@
153153 * Add a class if 'missingsummary' is triggered to allow styling of the summary
154154 line
155155 * Add CSS defintion of the 'wikitable' class to shared.css
156 -* (bug 17163) Added MediaWiki:Talkpage which will be displayed when viewing talk
157 - pages
 156+* (bug 17163) Added MediaWiki:Talkpageheader which will be displayed when
 157+ viewing talk pages
158158 * Add group convertsion support for LanguageConverter. New magic word "{{GROUPCONVERT:xxx}}"
159159 enabled for this new feature. You can set related conversion rules in
160160 [[MediaWiki:Groupconversiontable-xxx/language_code]].

Follow-up revisions

RevisionCommit summaryAuthorDate
r49028Fix regression from r48990nikerabbit09:47, 30 March 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r48930* (bug 17163) Added MediaWiki:Talkpage which will be displayed when viewing t...ialex20:22, 27 March 2009

Status & tagging log