r48934 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48933‎ | r48934 | r48935 >
Date:20:46, 27 March 2009
Author:aaron
Status:ok (Comments)
Tags:
Comment:
[schema change] Added 'verified' status level. Used and renamed existing SQL file since they don't build on each other.
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/CodeRevision.php (modified) (history)
  • /trunk/extensions/CodeReview/archives/codereview-cr_status.sql (added) (history)
  • /trunk/extensions/CodeReview/archives/codereview-reverted.sql (deleted) (history)
  • /trunk/extensions/CodeReview/codereview.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/codereview.sql
@@ -52,7 +52,7 @@
5353 -- 'resolved': Issues with this rev have been since resolved
5454 -- 'ok': Reviewed, no issues
5555 -- 'deferred': Not reviewed at this time (usually non-Wikimedia extension)
56 - cr_status enum('new', 'fixme', 'reverted', 'resolved', 'ok', 'deferred') not null default 'new',
 56+ cr_status enum('new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred') not null default 'new',
5757
5858 -- Base path of this revision :
5959 -- * if the revision change only one file, the file path
Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -74,6 +74,7 @@
7575 'code-status-reverted' => 'reverted',
7676 'code-status-resolved' => 'resolved',
7777 'code-status-ok' => 'ok',
 78+ 'code-status-verified' => 'verified',
7879 'code-status-deferred' => 'deferred',
7980 'code-pathsearch-legend' => 'Search revisions in this repo by path',
8081 'code-pathsearch-path' => 'Path:',
Index: trunk/extensions/CodeReview/archives/codereview-reverted.sql
@@ -1,2 +0,0 @@
2 -ALTER TABLE /*$wgDBprefix*/code_rev
3 - CHANGE `cr_status` `cr_status` ENUM( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'deferred' ) NOT NULL DEFAULT 'new';
Index: trunk/extensions/CodeReview/archives/codereview-cr_status.sql
@@ -0,0 +1,4 @@
 2+ALTER TABLE /*$wgDBprefix*/code_rev
 3+ CHANGE `cr_status` `cr_status`
 4+ ENUM( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred' )
 5+ NOT NULL DEFAULT 'new';
Property changes on: trunk/extensions/CodeReview/archives/codereview-cr_status.sql
___________________________________________________________________
Name: svn:eol-style
16 + native
Index: trunk/extensions/CodeReview/CodeRevision.php
@@ -93,7 +93,7 @@
9494 }
9595
9696 public static function getPossibleStates() {
97 - return array( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'deferred' );
 97+ return array( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred' );
9898 }
9999
100100 public function isValidStatus( $status ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r48937Add comment for r48934...simetrical21:55, 27 March 2009

Comments

#Comment by Voice of All (talk | contribs)   20:48, 27 March 2009

Status & tagging log