r48910 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48909‎ | r48910 | r48911 >
Date:06:01, 27 March 2009
Author:werdna
Status:ok
Tags:
Comment:
properly revert r48775 r48778
Modified paths:
  • /trunk/extensions/CentralAuth/SpecialGlobalGroupMembership.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/SpecialGlobalGroupMembership.php
@@ -93,14 +93,14 @@
9494 LogEventsList::showLogExtract( $output, 'gblrights', $pageTitle->getPrefixedText() );
9595 }
9696
97 - static function addLogEntry( $user, $oldGroups, $newGroups, $reason ) {
 97+ function addLogEntry( $user, $oldGroups, $newGroups ) {
9898 global $wgRequest;
9999
100100 $log = new LogPage( 'gblrights' );
101101
102102 $log->addEntry( 'usergroups',
103103 $user->getUserPage(),
104 - $reason,
 104+ $wgRequest->getText( 'user-reason' ),
105105 array(
106106 $this->makeGroupNameList( $oldGroups ),
107107 $this->makeGroupNameList( $newGroups )

Follow-up revisions

RevisionCommit summaryAuthorDate
r48970Redo r48746 (API userrights, reverted in r48909 and r48910) in a way that doe...catrope19:08, 28 March 2009
r50098Backport r48910: changing CentralAuth to match the core change due to the bac...tstarling06:43, 1 May 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r48775Fix fatal introduced somewhere along the line (probably by core changes)werdna00:53, 25 March 2009
r48778Implement changes from r48746 in subclassers of Userrightspage, avoid warningswerdna01:30, 25 March 2009

Status & tagging log