r48840 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48839‎ | r48840 | r48841 >
Date:18:32, 25 March 2009
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Don't filter log if there are a lot of relevant items
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
@@ -143,6 +143,8 @@
144144 $ids = $this->logids;
145145 break;
146146 }
 147+ // Just get the whole log if there are a lot if items
 148+ if( $ids > 20 ) return null;
147149 // Digit chars only
148150 foreach( $ids as $id ) {
149151 if( preg_match( '/^\d+$/', $id, $m ) ) {

Comments

#Comment by Brion VIBBER (talk | contribs)   23:17, 15 April 2009

This seems kind of odd to me; a case where there are many things is more likely to need filtering, surely?

#Comment by Aaron Schulz (talk | contribs)   03:52, 26 May 2009

Removed in r50567

Status & tagging log