r48818 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48817‎ | r48818 | r48819 >
Date:13:57, 25 March 2009
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Use preg_match_all to get all rev references
Modified paths:
  • /trunk/extensions/CodeReview/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRevision.php
@@ -183,7 +183,7 @@
184184 $dbw->insert( 'code_paths', $data, __METHOD__, array( 'IGNORE' ) );
185185 }
186186 // Update code relations (One-digit revs skipped due to some false-positives)
187 - if ( preg_match( '/\br(\d{2,})\b/', $this->mMessage, $m ) ) {
 187+ if ( preg_match_all( '/\br(\d{2,})\b/', $this->mMessage, $m ) ) {
188188 $data = array();
189189 unset($m[0]); // ignore the whole match
190190 foreach( $m as $rev ) {

Comments

#Comment by Aaron Schulz (talk | contribs)   15:25, 25 March 2009

Fix in r48831

Status & tagging log