r48642 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r48641‎ | r48642 | r48643 >
Date:20:21, 20 March 2009
Author:midom
Status:ok (Comments)
Tags:
Comment:
Every time someone relies on equality propagation, god kills a kitten
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRevisions.php
——@@ -254,7 +254,9 @@
255255
256256 // Get all page IDs
257257 $this->addWhereFld('page_id', array_keys($titles));
258 -
 258+ // Every time someone relies on equality propagation, god kills a kitten :)
 259+ $this->addWhereFld('rev_page', array_keys($titles));
 260+
259261 if(!is_null($params['continue']))
260262 {
261263 $cont = explode('|', $params['continue']);

Comments

#Comment by Catrope (talk | contribs)   20:26, 20 March 2009

I don't really understand how this commit is necessary. If the WHERE on page_id were replaced by one on rev_page, I'd understand, but having both in addition to rev_page=page_id seems kind of pointless to me; I'm not aware this is being done anywhere else in MediaWiki.

#Comment by Midom (talk | contribs)   20:57, 20 March 2009

well, consider this was 'replaced with rev_page', just supports query plan in multiple directions.

#Comment by Sunwell5 (talk | contribs)   17:24, 21 March 2009

Someone needs to add Extension:Duplicator into core code.

Status & tagging log