r48585 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48584‎ | r48585 | r48586 >
Date:17:32, 19 March 2009
Author:dale
Status:deferred
Tags:
Comment:
version bump for fresh js
fixed bug in array mapping of semantic properties
Modified paths:
  • /trunk/extensions/MetavidWiki/includes/MV_Index.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_Navigator.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_StreamImage.php (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/mv_embed.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/includes/MV_StreamImage.php
@@ -104,6 +104,10 @@
105105 }
106106 }
107107 function getStreamImageRaw( $stream_id, $req_time = null, $req_size = null ) {
 108+ //set out a long expire:
 109+ //keep in the cache for a 90 days:
 110+ header('Expires: ' . gmdate('D, d M Y H:i:s', time()+90*24*60*60) . ' GMT');
 111+
108112 // print "get raw img\n";
109113 $req_time = MV_StreamImage::procRequestTime( $stream_id, $req_time );
110114 list( $im_width, $im_height, $ext ) = MV_StreamImage::getSizeType( $req_size );
@@ -114,10 +118,7 @@
115119 $img_path = MV_StreamImage::getLocalImagePath( $stream_id, $req_time, $req_size );
116120 list( $im_width, $im_height, $ext ) = MV_StreamImage::getSizeType( $req_size );
117121 if ( $ext == 'jpg' )header( "Content-type: image/jpeg" );
118 - if ( $ext == 'png' )header( "Content-type: image/png" );
119 - //set out a long expire:
120 - //keep in the cache for a 90 days:
121 - header('Expires: ' . gmdate('D, d M Y H:i:s', time()+90*24*60*60) . ' GMT');
 122+ if ( $ext == 'png' )header( "Content-type: image/png" );
122123 // print "img path: $img_path";
123124 // @@todo a redirect to real image (will serv from cache that way)
124125 if ( is_file( $img_path ) ) {
Index: trunk/extensions/MetavidWiki/includes/MV_Index.php
@@ -108,7 +108,9 @@
109109 if ( $dbr->numRows( $result ) == 0 )return array();
110110
111111 $do_cat_lookup = $do_smw_lookup = false;
112 - $smw_properties = explode( ',', $smw_properties );
 112+ if( !is_array($smw_properties) ){
 113+ $smw_properties = explode( ',', $smw_properties );
 114+ }
113115 foreach($smw_properties as $propKey){
114116 if($propKey == 'category')
115117 $do_cat_lookup=true;
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_Navigator.php
@@ -50,6 +50,7 @@
5151 $options = array( 'LIMIT' => 1, 'ORDER BY' => $orderby )
5252 );
5353 //print $dbr->lastQuery();
 54+ //print_r($mvd_rows);
5455 //die;
5556 // print "SHOULD GET $pntype for $stream_time_req";
5657 reset( $mvd_rows );
@@ -78,7 +79,6 @@
7980 }
8081 }
8182 }
82 -
8383 return $o;
8484 }
8585 function render_full() {
Index: trunk/extensions/MetavidWiki/skins/mv_embed/mv_embed.js
@@ -22,7 +22,7 @@
2323 }
2424
2525 //used to grab fresh copies of scripts. (should be changed on commit)
26 -var MV_EMBED_VERSION = '1.0r11';
 26+var MV_EMBED_VERSION = '1.0r12';
2727
2828 //if we should use the scriptLoader
2929 //( lets you group requests, minimize javascript, and use mediaWiki localization infrastructure)

Status & tagging log