r48488 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r48487‎ | r48488 | r48489 >
Date:15:18, 17 March 2009
Author:catrope
Status:ok (Comments)
Tags:
Comment:
API: Fix E_NOTICE which broke displaying of legacy restrictions (page.page_restrictions) in prop=info
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryInfo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryInfo.php
——@@ -345,7 +345,7 @@
346346 $this->protections[$row->page_namespace][$row->page_title][] = $a;
347347
348348 # Also check old restrictions
349 - if($pageRestrictions[$row->pr_page]) {
 349+ if($this->pageRestrictions[$row->pr_page]) {
350350 $restrictions = explode(':', trim($this->pageRestrictions[$row->pr_page]));
351351 foreach($restrictions as $restrict) {
352352 $temp = explode('=', trim($restrict));

Comments

#Comment by Brion VIBBER (talk | contribs)   22:01, 17 March 2009

Check if this needs backporting to 1.14?

#Comment by Catrope (talk | contribs)   22:03, 17 March 2009

No, this is a regression from r47214

Status & tagging log