r47889 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47888‎ | r47889 | r47890 >
Date:11:58, 28 February 2009
Author:aaron
Status:ok
Tags:
Comment:
* Removed force index broken by r45764; shouldn't be needed anyway
* Mark function as public
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -3316,8 +3316,8 @@
33173317 'rev_page = ' . intval( $this->getArticleId() ) .
33183318 ' AND rev_id > ' . intval( $old ) .
33193319 ' AND rev_id < ' . intval( $new ),
3320 - __METHOD__,
3321 - array( 'USE INDEX' => 'PRIMARY' ) );
 3320+ __METHOD__
 3321+ );
33223322 }
33233323
33243324 /**
@@ -3336,7 +3336,7 @@
33373337 /**
33383338 * Callback for usort() to do title sorts by (namespace, title)
33393339 */
3340 - static function compare( $a, $b ) {
 3340+ public static function compare( $a, $b ) {
33413341 if( $a->getNamespace() == $b->getNamespace() ) {
33423342 return strcmp( $a->getText(), $b->getText() );
33433343 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45764For backport to 1.14....tstarling06:56, 15 January 2009

Status & tagging log