r47888 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47887‎ | r47888 | r47889 >
Date:04:50, 28 February 2009
Author:aaron
Status:ok
Tags:
Comment:
Made resetArticleID( 0 ) actually set the ID to zero. "false" can be used to unload (set to -1) it.
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -2576,7 +2576,6 @@
25772577
25782578 # Clear the cached article id so the interface doesn't act like we exist
25792579 $this->mTitle->resetArticleID( 0 );
2580 - $this->mTitle->mArticleID = 0;
25812580
25822581 # Log the deletion, if the page was suppressed, log it at Oversight instead
25832582 $logtype = $suppress ? 'suppress' : 'delete';
Index: trunk/phase3/includes/Title.php
@@ -2110,7 +2110,7 @@
21112111 $linkCache = LinkCache::singleton();
21122112 $linkCache->clearBadLink( $this->getPrefixedDBkey() );
21132113
2114 - if ( 0 == $newid ) { $this->mArticleID = -1; }
 2114+ if ( $newid === false ) { $this->mArticleID = -1; }
21152115 else { $this->mArticleID = $newid; }
21162116 $this->mRestrictionsLoaded = false;
21172117 $this->mRestrictions = array();

Status & tagging log