r47801 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47800‎ | r47801 | r47802 >
Date:14:42, 25 February 2009
Author:catrope
Status:ok
Tags:
Comment:
Slight fix for r47781: remove useless if($index) conditional: $index is always set and non-false
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryLogEvents.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryLogEvents.php
@@ -115,9 +115,9 @@
116116 // Use the title index in preference to the user index if there is a conflict
117117 $index = is_null($user) ? 'page_time' : array('page_time','user_time');
118118 }
119 - if ( $index ) {
120 - $this->addOption( 'USE INDEX', array( 'logging' => $index ) );
121 - }
 119+
 120+ $this->addOption( 'USE INDEX', array( 'logging' => $index ) );
 121+
122122 // Paranoia: avoid brute force searches (bug 17342)
123123 if (!is_null($title)) {
124124 $this->addWhere('log_deleted & ' . LogPage::DELETED_ACTION . ' = 0');

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47781INDEX use fixesaaron04:33, 25 February 2009

Status & tagging log