r47769 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47768‎ | r47769 | r47770 >
Date:22:27, 24 February 2009
Author:werdna
Status:ok (Comments)
Tags:
Comment:
Make $wgUseTagFilter disable just filtering, rather than all display query modification
Modified paths:
  • /trunk/phase3/includes/ChangeTags.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangeTags.php
@@ -93,10 +93,6 @@
9494 static function modifyDisplayQuery( &$tables, &$fields, &$conds, &$join_conds, $filter_tag = false ) {
9595 global $wgRequest, $wgUseTagFilter;
9696
97 - if( !$wgUseTagFilter ) {
98 - return;
99 - }
100 -
10197 if ($filter_tag === false) {
10298 $filter_tag = $wgRequest->getVal( 'tagfilter' );
10399 }
@@ -118,7 +114,7 @@
119115 $join_conds['tag_summary'] = array( 'LEFT JOIN', "ts_$join_cond=$join_cond" );
120116 $fields[] = 'ts_tags';
121117
122 - if ($filter_tag) {
 118+ if ($wgUseTagFilter && $filter_tag) {
123119 // Somebody wants to filter on a tag.
124120 // Add an INNER JOIN on change_tag
125121

Comments

#Comment by Brion VIBBER (talk | contribs)   22:43, 24 February 2009

Fixes bug in r47767

Status & tagging log