r47740 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r47739‎ | r47740 | r47741 >
Date:09:57, 24 February 2009
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
(bug 17282) Disallow users renames to usernames otherwise forbidden on creation
Modified paths:
  • /trunk/extensions/Renameuser/SpecialRenameuser_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Renameuser/SpecialRenameuser_body.php
——@@ -188,7 +188,7 @@
189189
190190 // Suppress username validation of old username
191191 $olduser = User::newFromName( $oldusername->getText(), false );
192 - $newuser = User::newFromName( $newusername->getText() );
 192+ $newuser = User::newFromName( $newusername->getText(), 'creatable' );
193193
194194 // It won't be an object if for instance "|" is supplied as a value
195195 if( !is_object( $olduser ) ) {

Comments

#Comment by Brion VIBBER (talk | contribs)   22:24, 3 March 2009

Should probably be reverted; admins are supposed to be able to override blacklists and such.

#Comment by Werdna (talk | contribs)   02:37, 25 March 2009

It isn't for blacklists, it just prevents stuff like @ et al.

Status & tagging log